NXCM-3600: Reworking ITs a bit, added 2nd IT

2nd IT covers the "real thing", it uses a "private repository" and does basically the same access tests as 1st one, but notice the slight differences in response codes!
sonatype · Dec 21, 2011 · f2b84db · f2b84db
1 parent e2eca1a
commit f2b84db
Show file tree

Hide file tree

Showing 5 changed files with 308 additions and 63 deletions.
diff --git a/...its/src/test/java/org/sonatype/nexus/integrationtests/nexus537/Nexus537RepoTargetsIT.java b/...its/src/test/java/org/sonatype/nexus/integrationtests/nexus537/Nexus537RepoTargetsIT.java
@@ -151,7 +151,7 @@ public void resetTestUserPrivs()
 
     @Override
     protected void overwriteUserRole( String userId, String newRoleName, String... permissions )
-        throws Exception
+        throws IOException
     {
         super.overwriteUserRole( userId, newRoleName, permissions );
         this.giveUserPrivilege( TEST_USER_NAME, "repository-all" );

diff --git a/...st/java/org/sonatype/nexus/integrationtests/nxcm3600/AbstractNxcm3600IntegrationTest.java b/...st/java/org/sonatype/nexus/integrationtests/nxcm3600/AbstractNxcm3600IntegrationTest.java
@@ -0,0 +1,97 @@
+/**
+ * Copyright (c) 2008-2011 Sonatype, Inc.
+ * All rights reserved. Includes the third-party code listed at http://links.sonatype.com/products/nexus/oss/attributions
+ *
+ * This program is free software: you can redistribute it and/or modify it only under the terms of the GNU Affero General
+ * Public License Version 3 as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied
+ * warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU Affero General Public License Version 3
+ * for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License Version 3 along with this program.  If not, see
+ * http://www.gnu.org/licenses.
+ *
+ * Sonatype Nexus (TM) Open Source Version is available from Sonatype, Inc. Sonatype and Sonatype Nexus are trademarks of
+ * Sonatype, Inc. Apache Maven is a trademark of the Apache Foundation. M2Eclipse is a trademark of the Eclipse Foundation.
+ * All other trademarks are the property of their respective owners.
+ */
+package org.sonatype.nexus.integrationtests.nxcm3600;
+
+import java.io.IOException;
+import java.net.URL;
+
+import org.restlet.data.MediaType;
+import org.restlet.data.Method;
+import org.restlet.data.Response;
+import org.restlet.data.Status;
+import org.sonatype.nexus.integrationtests.AbstractPrivilegeTest;
+import org.sonatype.nexus.integrationtests.RequestFacade;
+import org.sonatype.nexus.integrationtests.TestContainer;
+import org.sonatype.nexus.rest.model.RepositoryBaseResource;
+import org.sonatype.nexus.test.utils.RepositoryMessageUtil;
+
+/**
+ * See NXCM-3600 issue for test description.
+ * 
+ * @author cstamas
+ */
+public class AbstractNxcm3600IntegrationTest
+    extends AbstractPrivilegeTest
+{
+    private final RepositoryMessageUtil repositoryMessageUtil;
+
+    public AbstractNxcm3600IntegrationTest()
+    {
+        super( REPO_TEST_HARNESS_RELEASE_REPO );
+        this.repositoryMessageUtil = new RepositoryMessageUtil( this, getXMLXStream(), MediaType.APPLICATION_XML );
+    }
+
+    protected RepositoryMessageUtil getRepositoryMessageUtil()
+    {
+        return repositoryMessageUtil;
+    }
+
+    /**
+     * Sets the exposed flag of repository.
+     * 
+     * @param exposed
+     * @throws IOException
+     */
+    protected void setExposed( final boolean exposed )
+        throws IOException
+    {
+        TestContainer.getInstance().getTestContext().useAdminForRequests();
+        TestContainer.getInstance().getTestContext().setSecureTest( true );
+        final RepositoryBaseResource releasesRepository =
+            getRepositoryMessageUtil().getRepository( REPO_TEST_HARNESS_RELEASE_REPO );
+        releasesRepository.setExposed( exposed );
+        getRepositoryMessageUtil().updateRepo( releasesRepository );
+    }
+
+    protected Status sendMessage( final boolean authenticated, final URL url, Method method )
+        throws IOException
+    {
+        Response response = null;
+
+        final boolean wasSecureTest = TestContainer.getInstance().getTestContext().isSecureTest();
+
+        try
+        {
+            TestContainer.getInstance().getTestContext().setSecureTest( authenticated );
+
+            response = RequestFacade.sendMessage( url, method, null );
+
+            return response.getStatus();
+        }
+        finally
+        {
+            if ( response != null )
+            {
+                RequestFacade.releaseResponse( response );
+            }
+
+            TestContainer.getInstance().getTestContext().setSecureTest( wasSecureTest );
+        }
+    }
+}
diff --git a/...sts/nxcm3600/Nxcm3600IntegrationTest.java → .../nxcm3600/Nxcm3600IntegrationCase1IT.java b/...sts/nxcm3600/Nxcm3600IntegrationTest.java → .../nxcm3600/Nxcm3600IntegrationCase1IT.java
@@ -20,82 +20,29 @@
 
 import static org.hamcrest.Matchers.equalTo;
 
-import java.io.File;
 import java.io.IOException;
-import java.net.URL;
 
 import org.hamcrest.MatcherAssert;
-import org.restlet.data.MediaType;
 import org.restlet.data.Method;
-import org.restlet.data.Response;
 import org.restlet.data.Status;
-import org.sonatype.nexus.integrationtests.AbstractNexusIntegrationTest;
 import org.sonatype.nexus.integrationtests.RequestFacade;
-import org.sonatype.nexus.integrationtests.TestContainer;
 import org.sonatype.nexus.rest.model.GlobalConfigurationResource;
-import org.sonatype.nexus.rest.model.RepositoryBaseResource;
-import org.sonatype.nexus.test.utils.RepositoryMessageUtil;
 import org.sonatype.nexus.test.utils.SettingsMessageUtil;
 import org.testng.annotations.Test;
 
 /**
- * See NXCM-3600 issue for test description.
+ * Case1 of NXCM-3600: anon access disabled.
  * 
  * @author cstamas
  */
-public class Nxcm3600IntegrationTest
-    extends AbstractNexusIntegrationTest
+public class Nxcm3600IntegrationCase1IT
+    extends AbstractNxcm3600IntegrationTest
 {
-    private final RepositoryMessageUtil repositoryMessageUtil;
-
-    private final File junkYard;
-
-    public Nxcm3600IntegrationTest()
-    {
-        super( REPO_TEST_HARNESS_RELEASE_REPO );
-        this.repositoryMessageUtil = new RepositoryMessageUtil( this, getXMLXStream(), MediaType.APPLICATION_XML );
-        // prepare some files used across test
-        this.junkYard = new File( nexusBaseDir, "nxcm3600-junk" );
-        this.junkYard.mkdirs();
-    }
-
-    protected void setExposed( final boolean exposed )
-        throws IOException
-    {
-        TestContainer.getInstance().getTestContext().useAdminForRequests();
-        TestContainer.getInstance().getTestContext().setSecureTest( true );
-        final RepositoryBaseResource releasesRepository =
-            repositoryMessageUtil.getRepository( REPO_TEST_HARNESS_RELEASE_REPO );
-        releasesRepository.setExposed( exposed );
-        repositoryMessageUtil.updateRepo( releasesRepository );
-    }
-
-    protected Status sendMessage( final boolean authenticated, final URL url, Method method )
-        throws IOException
-    {
-        Response response = null;
-
-        final boolean wasSecureTest = TestContainer.getInstance().getTestContext().isSecureTest();
-
-        try
-        {
-            TestContainer.getInstance().getTestContext().setSecureTest( authenticated );
-
-            response = RequestFacade.sendMessage( url, method, null );
-
-            return response.getStatus();
-        }
-        finally
-        {
-            if ( response != null )
-            {
-                RequestFacade.releaseResponse( response );
-            }
-
-            TestContainer.getInstance().getTestContext().setSecureTest( wasSecureTest );
-        }
-    }
-
+    /**
+     * In Case1, we simply disable anonymous access totally, and asserts the expectations.
+     * 
+     * @throws IOException
+     */
     @Test
     public void testCase1()
         throws IOException

diff --git a/...rc/test/java/org/sonatype/nexus/integrationtests/nxcm3600/Nxcm3600IntegrationCase2IT.java b/...rc/test/java/org/sonatype/nexus/integrationtests/nxcm3600/Nxcm3600IntegrationCase2IT.java
@@ -0,0 +1,149 @@
+/**
+ * Copyright (c) 2008-2011 Sonatype, Inc.
+ * All rights reserved. Includes the third-party code listed at http://links.sonatype.com/products/nexus/oss/attributions
+ *
+ * This program is free software: you can redistribute it and/or modify it only under the terms of the GNU Affero General
+ * Public License Version 3 as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied
+ * warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU Affero General Public License Version 3
+ * for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License Version 3 along with this program.  If not, see
+ * http://www.gnu.org/licenses.
+ *
+ * Sonatype Nexus (TM) Open Source Version is available from Sonatype, Inc. Sonatype and Sonatype Nexus are trademarks of
+ * Sonatype, Inc. Apache Maven is a trademark of the Apache Foundation. M2Eclipse is a trademark of the Eclipse Foundation.
+ * All other trademarks are the property of their respective owners.
+ */
+package org.sonatype.nexus.integrationtests.nxcm3600;
+
+import static org.hamcrest.Matchers.equalTo;
+
+import java.io.IOException;
+
+import org.hamcrest.MatcherAssert;
+import org.restlet.data.Method;
+import org.restlet.data.Status;
+import org.sonatype.nexus.integrationtests.RequestFacade;
+import org.sonatype.nexus.integrationtests.TestContainer;
+import org.testng.annotations.Test;
+
+/**
+ * Case2 of NXCM-3600: private repository.
+ * 
+ * @author cstamas
+ */
+public class Nxcm3600IntegrationCase2IT
+    extends AbstractNxcm3600IntegrationTest
+{
+    /**
+     * In Case2, we make "private repository" the repository we test against. Notice how it slightly differs from Case1,
+     * where 404's are returned instead of 401.
+     * 
+     * @throws IOException
+     */
+    @Test
+    public void testCase2()
+        throws IOException
+    {
+        // make the testing repository "private"
+        enablePrivateRepository( TestContainer.getInstance().getTestContext().getAdminUsername(),
+            REPO_TEST_HARNESS_RELEASE_REPO );
+
+        Status responseStatus;
+
+        // verify assumptions, we have the stuff deployed and present
+        // try and verify authenticate /content GET access gives 200
+        responseStatus =
+            sendMessage(
+                true,
+                RequestFacade.toNexusURL( "content/repositories/" + REPO_TEST_HARNESS_RELEASE_REPO
+                    + "/nxcm3600/artifact/1.0.0/artifact-1.0.0.jar" ), Method.GET );
+        MatcherAssert.assertThat( responseStatus.getCode(), equalTo( 200 ) );
+        // try and verify authenticated /service/local GET access gives 200
+        responseStatus =
+            sendMessage(
+                true,
+                RequestFacade.toNexusURL( "service/local/repositories/" + REPO_TEST_HARNESS_RELEASE_REPO
+                    + "/content/nxcm3600/artifact/1.0.0/artifact-1.0.0.jar" ), Method.GET );
+        MatcherAssert.assertThat( responseStatus.getCode(), equalTo( 200 ) );
+        // try and verify anon /content GET access gives 401
+        responseStatus =
+            sendMessage(
+                false,
+                RequestFacade.toNexusURL( "content/repositories/" + REPO_TEST_HARNESS_RELEASE_REPO
+                    + "/nxcm3600/artifact/1.0.0/artifact-1.0.0.jar" ), Method.GET );
+        MatcherAssert.assertThat( responseStatus.getCode(), equalTo( 401 ) );
+        // try and verify anon /service/local GET access gives 401
+        responseStatus =
+            sendMessage(
+                false,
+                RequestFacade.toNexusURL( "service/local/repositories/" + REPO_TEST_HARNESS_RELEASE_REPO
+                    + "/content/nxcm3600/artifact/1.0.0/artifact-1.0.0.jar" ), Method.GET );
+        MatcherAssert.assertThat( responseStatus.getCode(), equalTo( 401 ) );
+
+        // now put repository into exposed=false mode
+        setExposed( false );
+
+        // READ access
+        // try and verify authenticated /content GET access gives 404
+        responseStatus =
+            sendMessage(
+                true,
+                RequestFacade.toNexusURL( "content/repositories/" + REPO_TEST_HARNESS_RELEASE_REPO
+                    + "/nxcm3600/artifact/1.0.0/artifact-1.0.0.jar" ), Method.GET );
+        MatcherAssert.assertThat( responseStatus.getCode(), equalTo( 404 ) );
+        // try and verify authenticated /service/local GET access gives 200
+        responseStatus =
+            sendMessage(
+                true,
+                RequestFacade.toNexusURL( "service/local/repositories/" + REPO_TEST_HARNESS_RELEASE_REPO
+                    + "/content/nxcm3600/artifact/1.0.0/artifact-1.0.0.jar" ), Method.GET );
+        MatcherAssert.assertThat( responseStatus.getCode(), equalTo( 200 ) );
+        // try and verify anon /content GET access gives 404
+        responseStatus =
+            sendMessage(
+                false,
+                RequestFacade.toNexusURL( "content/repositories/" + REPO_TEST_HARNESS_RELEASE_REPO
+                    + "/nxcm3600/artifact/1.0.0/artifact-1.0.0.jar" ), Method.GET );
+        MatcherAssert.assertThat( responseStatus.getCode(), equalTo( 404 ) );
+        // try and verify anon /service/local GET access gives 401
+        responseStatus =
+            sendMessage(
+                false,
+                RequestFacade.toNexusURL( "service/local/repositories/" + REPO_TEST_HARNESS_RELEASE_REPO
+                    + "/content/nxcm3600/artifact/1.0.0/artifact-1.0.0.jar" ), Method.GET );
+        MatcherAssert.assertThat( responseStatus.getCode(), equalTo( 401 ) );
+
+        // DELETE access
+        // try and verify authenticated /content DELETE access gives 404
+        responseStatus =
+            sendMessage(
+                true,
+                RequestFacade.toNexusURL( "content/repositories/" + REPO_TEST_HARNESS_RELEASE_REPO
+                    + "/nxcm3600/artifact/1.0.0/artifact-1.0.0.jar" ), Method.DELETE );
+        MatcherAssert.assertThat( responseStatus.getCode(), equalTo( 404 ) );
+        // try and verify authenticated /service/local DELETE access gives 404
+        responseStatus =
+            sendMessage(
+                true,
+                RequestFacade.toNexusURL( "service/local/repositories/" + REPO_TEST_HARNESS_RELEASE_REPO
+                    + "/content/nxcm3600/artifact/1.0.0/artifact-1.0.0.jar" ), Method.DELETE );
+        MatcherAssert.assertThat( responseStatus.getCode(), equalTo( 404 ) );
+        // try and verify anon /content DELETE access gives 404
+        responseStatus =
+            sendMessage(
+                false,
+                RequestFacade.toNexusURL( "content/repositories/" + REPO_TEST_HARNESS_RELEASE_REPO
+                    + "/nxcm3600/artifact/1.0.0/artifact-1.0.0.jar" ), Method.DELETE );
+        MatcherAssert.assertThat( responseStatus.getCode(), equalTo( 404 ) );
+        // try and verify anon /service/local DELETE access gives 404
+        responseStatus =
+            sendMessage(
+                false,
+                RequestFacade.toNexusURL( "service/local/repositories/" + REPO_TEST_HARNESS_RELEASE_REPO
+                    + "/content/nxcm3600/artifact/1.0.0/artifact-1.0.0.jar" ), Method.DELETE );
+        MatcherAssert.assertThat( responseStatus.getCode(), equalTo( 404 ) );
+    }
+}