This repository has been archived by the owner on Aug 11, 2020. It is now read-only.
o [NXCM-4425] Turn off calculation of page scroll offset for IE #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main Nexus UI does not scroll ever, so this calculation is unnecessary and slows down UI noticably (300ms<>1ms for a privilege detail view in my tests). This is still a bad hack, but fortunately other browsers are not affected.
|
this fix was tested by @nabcos and @peterlynch can't imagine others have a problem with it |
peterlynch
added a commit
that referenced
this pull request
Jul 9, 2012
o [NXCM-4425] Turn off calculation of page scroll offset for IE
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Nexus UI does not scroll ever, so this calculation is unnecessary
and slows down UI noticably (300ms<>1ms for a privilege detail view in
my tests). This is still a bad hack, but fortunately other browsers are
not affected.
[Peter] This fix improves performance in my tests to match other browsers with no apparent