This repository has been archived by the owner on Aug 11, 2020. It is now read-only.
Use the reference factory to get the baseUrl #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So, was it reference factory or non-relative URL? Or both? Anyway, both changes looks fine: 🍺 🍺 |
|
It was the fact that $nexusRoot was not giving the right URL, and we (unnecessary) had the absolute URL in the HTML. |
nabcos
added a commit
that referenced
this pull request
Nov 22, 2012
[NXCM-4804] Fix index template to use the right baseUrl + relative URLs for requirejs
|
@nabcos I was wondering why the full URL was used here ;-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.sonatype.org/browse/NXCM-4804