This repository has been archived by the owner on Aug 11, 2020. It is now read-only.
NXCM-4861: Fixing the ArtifactStoreHelper.storeItemWithChecksums method #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, current imple can result in remote item download for some proxy configuration, like itemAgingActive=false used by procurement. Fixing it, to enforce "localOnly" flag. Basically, same code is now executed as in case of cache (where also store+retrieve) happens, see: org.sonatype.nexus.proxy.repository.AbstractProxyRepository#doCacheItem Other minor cleanup (mostly javadoc) done. Added UT that verifies that maven repo now receives a retrieve with localOnly=true flag.
| import org.sonatype.nexus.proxy.storage.local.LocalRepositoryStorage; | ||
| import org.sonatype.sisu.litmus.testsupport.mock.MockitoRule; | ||
|
|
||
| public class Nxcm4861Test |
There was a problem hiding this comment.
This needs more descriptive name, that tells what the test actually tests, something like Nxcm4861ArtifactStoreHelper_storeItemWithChecksumsTest
| sb.append( "\")" ); | ||
| return sb.toString(); | ||
| return "ResourceStoreRequest{" + | ||
| "requestPath='" + requestPath + '\'' + |
There was a problem hiding this comment.
why add the artificial slash here? to request path
...and before it was a leading slash, now it is added at end.
cstamas
added a commit
that referenced
this pull request
Jan 4, 2013
NXCM-4861: Fixing the ArtifactStoreHelper.storeItemWithChecksums method
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, current imple can result in remote item download
for some proxy configuration, like itemAgingActive=false used by
procurement.
Fixing it, to enforce "localOnly" flag. Basically, same code
is now executed as in case of cache (where also store+retrieve)
happens, see:
org.sonatype.nexus.proxy.repository.AbstractProxyRepository#doCacheItem
Other minor cleanup (mostly javadoc) done.
Added UT that verifies that maven repo now receives a retrieve
with localOnly=true flag.