Skip to content
This repository has been archived by the owner on Aug 11, 2020. It is now read-only.

Add fix for encoding problems #1

Closed
wants to merge 4 commits into from
Closed

Conversation

kreyssel
Copy link
Contributor

We had some issues with german umlauts in encoded passwords.

I'm looking into PBECipher and found that he use not always string encoding.

Hope you can this add to maven core too.

@bentmann
Copy link
Contributor

Good catch, thanks! But before merging this in, could you fix the following minor things:

  • Use 2-spaces as intend in the POM, i.e. basically use the existing formatting
  • Use UTF-8 or maybe Unicode escapes for the umlauts in the tests? Right now, the file appears to be using Latin-1 whereas the sources are (meant to be) encoded in UTF-8.

@kreyssel
Copy link
Contributor Author

Ok, switched to 2 spaces for POM.

Can you recheck encoding of PBECipherTest.java? I think that i have switched encoding in commit 12de44c - take a look at wrong encoding in first commit 6ccec0e.

@kreyssel
Copy link
Contributor Author

Added issue for maven to include it in a new release.

http://jira.codehaus.org/browse/MNG-5131

@bentmann
Copy link
Contributor

Merged, thank you!

@bentmann bentmann closed this Jul 12, 2011
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants