This repository has been archived by the owner on Aug 11, 2020. It is now read-only.
Fix issue 745 Properly decode URL paths #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I won't create 3.1.x "backport" as the patch cleanly applies against latest release 3.1.9 too, and all the tests passes (tried locally). |
|
Looks reasonable, do you need this in a .1 patch release or is the next release acceptable? |
mcculls
added a commit
that referenced
this pull request
Feb 14, 2014
Issue 745: properly decode URL paths
|
I tested Nx with patched 3.1.9, so unless you know for any blocked why NOT to bump sisu-guice to next release, I'd say go with next one. |
|
Staged as 3.1.10 on RSO for testing... let me know when you want it released to central |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem was that wrapped HttpServletRequest prepped by ServletDefinition used request methods that returns non-decoded path to craft pathInfo, that must be decoded.
Issue
https://code.google.com/p/google-guice/issues/detail?id=745