Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit rinfo to server request handlers #10

Merged
merged 1 commit into from Feb 6, 2020

Conversation

arbitrarytech
Copy link
Contributor

I'm looking to build a DNS server that has conditional behavior based on the source of DNS requests. Currently, the server in this library doesn't surface the remote information to request handlers. This change allows a handler like server.on('request', (request, send, rinfo) => {}) and will not break any existing interfaces.

I'm looking to build a DNS server that has conditional behavior based on the source of DNS requests. Currently, the server in this library doesn't surface the remote information to request handlers. This change allows a handler like `server.on('request', (request, send, rinfo) => {})` and will not break any existing interfaces.
Copy link
Owner

@song940 song940 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@song940 song940 merged commit fc87c73 into song940:master Feb 6, 2020
@song940
Copy link
Owner

song940 commented Feb 6, 2020

@arbitrarytech dns2@1.3.1 published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants