Handle & report server request errors as 'requestError' events #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amazing, thanks for merging all these PRs so quickly! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42.
As discussed in that issue, without this change any invalid DNS packet can crash the server, e.g. by sending an empty UDP packet.
With this change, it's reported as a
requestErrorevent (not anerrorevent, so implementers can ignore this without crashing Node.js if they choose to) and the request is safely ignored.The changeset for DoH may look large, but that's just due to indentation changes - disable whitespace diffs to see the real change.
It might be possible to improve on this by:
I don't think either are especially urgent though, whereas it's quite important to ensure that the server doesn't crash completely when sent trivially invalid input.