fix for mips compile #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue detail : golang/go#21596 const is untyped int
songgao
requested changes
Sep 12, 2017
syscalls_linux.go
Outdated
| @@ -22,7 +22,7 @@ type ifReq struct { | |||
| pad [0x28 - 0x10 - 2]byte | |||
| } | |||
|
|
|||
| func ioctl(fd uintptr, request int, argp uintptr) error { | |||
| func ioctl(fd uintptr, request uint, argp uintptr) error { | |||
There was a problem hiding this comment.
Looks like uintptr is a better choice, given that Syscall expects that exact argument. Would you mind changing to that?
I think I used int here originally since this parameter being a pointer felt weird to me, and I just assumed it was always typed as int.
|
@songgao yes，I build a gateway which run in openwrt/lede router. I have already change，thanks for your suggestion. |
songgao
approved these changes
Sep 19, 2017
|
Thanks for fixing; I forgot to ask last time; could you please add yourself into |
|
sorry for delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue detail : golang/go#21596
const is untyped int