fix: Numeric Sorting in Tables #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed that similar sorting functions are used in other tables. Among which the channel sorting method (681fcab) already takes into account the numeric case. For the sake of consistency across all tables, I've revised the sorting mechanism to align with the approach used in other tables. |
BaksiLi
changed the title
|
Thx~ |
ckt1031
pushed a commit
to ckt1031/one-api
that referenced
this pull request
Nov 10, 2023
* Update sorting method for id * Update sorting method for id (token) * Update sorting method for id (redemptions) * Update sorting method for id (channel) * chore: use same logic for all tables --------- Co-authored-by: JustSong <songquanpeng@foxmail.com>
humphery755
added a commit
to humphery755/one-api
that referenced
this pull request
Nov 19, 2023
…ync-one-api * 'main' of https://github.com/songquanpeng/one-api: fix: cloudflare test & expose detailed info about test failures (songquanpeng#715) feat: support tts model (songquanpeng#713) feat: keep sync with dall-e updates (songquanpeng#679) fix: fix PaLM not working issue (songquanpeng#667) fix: fix channel_id column name (songquanpeng#681, close songquanpeng#688) feat: add improve docker-compose.yml and support fast startup (songquanpeng#685) docs: add deploy to zeabur button (songquanpeng#693) fix: numeric sorting in tables (songquanpeng#695) feat: sync pricing for new 1106 models (songquanpeng#696) docs: update readme chore: update quota calc logic (close songquanpeng#599) (songquanpeng#627) fix: fix Cloudflare AI Gateway channel test support (songquanpeng#639) feat: support chatglm_turbo (songquanpeng#648) fix: fix typo (songquanpeng#651)
greeeds
pushed a commit
to greeeds/one-api
that referenced
this pull request
Mar 3, 2024
* Update sorting method for id * Update sorting method for id (token) * Update sorting method for id (redemptions) * Update sorting method for id (channel) * chore: use same logic for all tables --------- Co-authored-by: JustSong <songquanpeng@foxmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue with the sorting function in the user table where numeric values were being treated as strings, leading to incorrect order.
Specifically, "10" was being sorted next to "1", rather than after "9".
This PR ensures that both numeric and string values are sorted correctly in the user table. See below: