SOC-3529 add support for pd merging #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt renaming things to use correct terms...
(try to) make it smart enough to pull an eventid from either an alert or an incident.
…ingle merged PD incident).
- Switched JSON encoding to using a JSON object instead of imported `to_json` so can "allow_blessed" for all json stuff. - Added a bunch of debugging stuff, including every func outputting its arguments on every call if DEBUG>=5. - Added logic and a couple functions for merging Zabbix events when PD incidents merge.
|
Needs to be more thoroughly tested in more scenarios (make sure didn't break anything that previously worked) and I'd like to look over the code to see if there's any improvements to readability (etc) I can make... |
Also a bit of just general docs/example improvements while I was in there.
…rking and doesn't add enough value to be worth digging into further (anything other than `merge` or `resolve` gets treated same as `ignore`). And a tiny bit more debugging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for #6