New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAI bulk add/remove implementation #246
Conversation
Needs a unit test before converting from draft |
LGTM, but I'll wait for some tests and try them out myself. |
Hi @marian-pritsak any chance we can get a unit test or two to validate this and accept it? |
@marian-pritsak |
@vmytnykx pointed out that the saithrift codegen (in SAI repo) lacks bulk support so it's unlikely we can use these bulk APIs in any saithrift tests in the near term. @chrispsommers pointed out we could write tests in c++ e.g. under tests/libsai. He also said the risk was low to accept w/o a test case so we can merge and handle any surprises later. Consensus seemed to be to merge it and move on. |
Hi @marian-pritsak we've agreed to merge but there is a "status" issue. I don't understand it. |
Git command 'amend' and git push force - rinse and repeat? Vincent has seen this before... |
@marian-pritsak to update tomorrow 3/30/2023 |
Signed-off-by: Marian Pritsak <marianp@mellanox.com>
Signed-off-by: Marian Pritsak marianp@mellanox.com