minor fixes (passed value and removal ordering) in testcases #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
vincent-xs
force-pushed
the
xsight_sai_integration
branch
2 times, most recently
from
2daa51c
to
c496896
Compare
aputriax
approved these changes
Mar 21, 2023
|
@vincent-xs please complete the CLA process, thanks. |
|
Looks good. Thanks! |
vincent-xs
force-pushed
the
xsight_sai_integration
branch
6 times, most recently
from
e2bb6e1
to
03232c8
Compare
vincent-xs
force-pushed
the
xsight_sai_integration
branch
from
03232c8
to
f6bb49e
Compare
|
Kristina to merge today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the vni passed in saidasheni.py was incorrect
the outbound route needs to be removed before the ENI (reverse order of create)