PoE design proposal HLD document #1631
Conversation
Signed-off-by: Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>
|
community review recording https://zoom.us/rec/share/Rx4P62u1hfWkAH2kMgyIP-SoWcQfeQrkgM3hvuv8AsMjNJMWQT70dBOcx6GqmnXe.52gMDrInKWQmT0E4 |
|
Design is not according to SONiC design philosophy. Without significant requirement or necessity another syncD has been added for POE. Multiple syncD module in SONiC architecture is not a SONiC design philosophy. Also PoE is a hardware feature i.e. feature attached to physical interface and not related to ASIC forwarding. Hence using syncD module for management of this feature is not a right way of feature designing in SONiC. Here we have to follow management POE feature same way how PMON manages fan and power using PDDF framework. In recording team was mentioning about performance impact if we use PDDF framework but I could not get right justification. |
- add SWSS cahnges - include LLDP interaction - add example PoE config - mention about warm reboot requirements Signed-off-by: Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>
|
My review comment is not addressed yet. |
We want to utilize SAI as the standard API for PoE. This will allow PoE chip vendors to provide SAI library for their PoE devices. Usually, NPU and PoE chips are from different vendors, thus a need for a separate syncd container. |
|
Is there any plan about SNMP? I think SNMP can also control the PoE. |
|
Can we also have the code PRs listed in this HLD PR? Thanks. |
|
|
||
| #### PoE SYNCD | ||
|
|
||
| New PoE SYNCD container componnents: |
There was a problem hiding this comment.
what is the reason to have a poe syncd? why normal syncd won't work. isn't that poe feature is captured with SAI api, then normal syncd can support poe as long as the sai library support poe?
There was a problem hiding this comment.
I believe the motivation is to allow use of an additional instance of SAI. one for NPU and one for PoE. This is assuming that NPU and PoE HW and drivers are developed by different vendors
|
|
||
| ### PoE Abstraction Interface | ||
|
|
||
| The PoE Manager uses a new SAI PoE library that implements the PoE Abstraction Interface. |
There was a problem hiding this comment.
can you share the poe sai library pr? is it already merged in sai?
There was a problem hiding this comment.
SAI PR -opencomputeproject/SAI#1977 (merged)
Implementation will be (PoE HW) vendor specific, we will be providing an example, working implementation for MicroChip PSE (in development)
Add PoE design proposal HLD document with the following content:
In order to isolate PoE functionality and complexity from existing SONiC design, the following main changes are made:
SAI community changes #1977