Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HLD] SONiC GNOI Server Interface Design #1644

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

isabelmsft
Copy link
Contributor

@isabelmsft isabelmsft commented Mar 27, 2024

[HLD] SONiC GNOI Server Interface Design

Feature PRs:

PR title state context
[sonic-host-services] Add dbus service to support restart and kill process GitHub issue/pull request detail GitHub pull request check contexts
[sonic-gnmi] Add KillProcess gNOI API. GitHub issue/pull request detail GitHub pull request check contexts

Test PRs:

PR title state context
[sonic-mgmt] Add E2E Tests for GNOI KillProcess API GitHub issue/pull request detail GitHub pull request check contexts

@isabelmsft isabelmsft changed the title [HLD] SONiC GNMI Server Interface Design [HLD] SONiC GNOI Server Interface Design Mar 27, 2024

Currently, most SONiC operation and configuration management requires directly using CLI on the device. This document proposes the addition of gNOI API to SONiC to modernize SONiC operation management.

GNOI (gRPC network operations interface) is supported through OpenConfig. All gNOI services and documentation are available on the [OpenConfig page](https://github.com/openconfig/gnoi). OpenConfig defines and implements a common, vendor-independent software layer for managing network devices.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please capture the steps/guidelines to extend the standard gnoi proto files for new fields if needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't currently have a plan to extend standard gNOI proto files for new fields. If the API needed is not already supported by gNOI or SONiC internal APIs, we have the following two options:

  1. Add new internal SONiC API (ref: https://github.com/sonic-net/sonic-gnmi/blob/master/proto/gnoi/sonic_gnoi.proto)
  2. Propose update to gNOI protocol

@zhangyanzhao
Copy link
Collaborator

qiluo-msft pushed a commit to sonic-net/sonic-host-services that referenced this pull request May 31, 2024
As part of the GNOI project (HLD: sonic-net/SONiC#1644), we require dbus support for service kill and restart.

This PR adds dbus support for service kill and restart, restricted to services snmp and swss to protect SONiC system in initial phases of this project.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants