[Logrotate] Add logrotate feature HLD #1683
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>
fastiuk
force-pushed
the
dev-logrotate-config
branch
from
f6d8a33
to
af5b905
Compare
fastiuk
changed the title
|
HLD is reviewed in community on 5/14/2024 |
|
call for reviewers, please leave your comments if you want to be a reviewer of this HLD. Thanks. |
madhupalu
reviewed
May 14, 2024
| It reads log rotate configuration from database and apply it to log rotate config files. | ||
|
|
||
|
|
||
| **The log rotate config files will be used:** |
There was a problem hiding this comment.
what is the default log rotation configuration?
| **The log rotate config files will be used:** | ||
| 1. /etc/logrotate.d/rsyslog - generic log files | ||
| 2. /etc/logrotate.d/debug - debug log files | ||
| 3. /etc/logrotate.d/syslog - syslog files |
There was a problem hiding this comment.
Mentioning the contents of these files would be helpful.
fastiuk
commented
May 14, 2024
|
|
||
| **User interface**: | ||
| ``` | ||
| config |
There was a problem hiding this comment.
We should be able to revert back the default value
|
|
||
|
|
||
| **The log rotate config files will be used:** | ||
| 1. /etc/logrotate.d/rsyslog - generic log files |
There was a problem hiding this comment.
Clarify the content and maybe change the name for an old file
|
community review recording https://zoom.us/rec/share/pxggDmJPYuO2cbCd3OALS8z-rce-qXfZ_-zX6AU7s1xWyIi2oSiw8eJJ_rBU0PMW.wlH1D2euCp9OJ-vS |
Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>
Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>
Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>
|
@saiarcot895 could you review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This document provides general information about log rotate implementation in SONiC
The scope of this document is to cover definition, design and implementation of SONiC log rotate feature and related CLI.