AAA restrictions hld #1690
Open
AAA restrictions hld #1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yarden-Z
reviewed
May 7, 2024
| enum authentication; | ||
| **enum restrictions;** | ||
| ** | ||
| leaf lockout_state { |
There was a problem hiding this comment.
Is this the main knob for enabling or disabling this feature?
There was a problem hiding this comment.
not exactly as it is independent from fail-delay.
the lockout_state is regarding the locking of users - to not use the blacklist. the delay on each login is not effected by this
There was a problem hiding this comment.
Then we should either have something that enables this feature as a whole, or add a build flag on whether we would like these items or not.
I'm more for the cli command, as it is cleaner.
| auth sufficient pam_faillock.so authsucc audit deny={{ attempts }} unlock_time={{ unlock_time }} | ||
| ``` | ||
| ### Flows | ||
| The flows are aaa sonic-based flows. |
There was a problem hiding this comment.
Just put regular AAA flows
There was a problem hiding this comment.
it is part of the referenced aaa improvements and would be just coping large sections of text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the HLD for intigrating restrictions under aaa authentication. improving general security and resilience against brute force attacks in particular.