HLD for Shutdown and Startup Fabric module #1694
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlok-nokia
force-pushed
the
shutdown_startup_fabric_hld
branch
from
1956135
to
88063c1
Compare
wumiaont
reviewed
May 8, 2024
mlok-nokia
force-pushed
the
shutdown_startup_fabric_hld
branch
from
88063c1
to
04ba416
Compare
Signed-off-by: mlok <marty.lok@nokia.com>
This was referenced May 14, 2024
abdosi
reviewed
May 15, 2024
abdosi
reviewed
May 15, 2024
abdosi
reviewed
May 15, 2024
abdosi
reviewed
May 15, 2024
abdosi
reviewed
May 15, 2024
|
@jfeng-arista for awareness |
abdosi
reviewed
May 22, 2024
anamehra
reviewed
May 22, 2024
| 2. Modify the module_db_update() to call get_module_admin_status() to check the config module. If the module_cfg_status is not set to down, then populate the CH-TBDASSIS_FABRIC_ASIC_TABLE. Otherwise, just ignore it even the SFM module is present. This mechanism prevents the event is triggered in the swss.sh when admin_status is set to down state. | ||
|
|
||
| # 3 Test Considerations | ||
| UTs are also added to simulate the Fabric shutdown and startup |
There was a problem hiding this comment.
We may need to consider sonic-mgmt test to cover this. The tests should cover validating effect on thermal and pci devices.
|
@abdosi @judyjoseph I have update the document with investigation of the Impact of PCIed and Thermal sensors. Based on the current implementation, there is NO impact. Please review it |
anamehra
reviewed
May 28, 2024
|
|
||
| # 3 Impact and Test Considerations | ||
| ## 3.1 Impact of the PCIed and Thermal sensors | ||
| For PCIed, based on the investigation, the current design of the Fabric module shutdown has NO impact on the PCIed. The PCIed current checks the basic PCI components. For the Fabric slot which is shutdown, if platform supports PCI on the Fabric card, it should check if its power is on that particular card before it is added to the PCIe check. That is how is handled in the Arista vendor code. |
There was a problem hiding this comment.
When Fabric is shutdown through CLI, the Vendor code needs to modify the pci device list and remove the the device from list. We would also need support to be able to update this list dynamically. Currently, it's loaded during boot with the start of pcied daemon. If the list is updated, this process needs to restart in the current implementation.
judyjoseph
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
May 29, 2024
…ule(SFM) by using "config chassis modules shutdown/startup" commands (#3283) sudo config chassis modules shutdown/startup <module name> The HLD for Shutdown and Startup of the Fabric Module is below: sonic-net/SONiC#1694
arfeigin
pushed a commit
to arfeigin/sonic-utilities
that referenced
this pull request
Jun 16, 2024
…ule(SFM) by using "config chassis modules shutdown/startup" commands (sonic-net#3283) sudo config chassis modules shutdown/startup <module name> The HLD for Shutdown and Startup of the Fabric Module is below: sonic-net/SONiC#1694
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is HLD for Shutdown and Startup the Fabric Module.