Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error from sonic-mgmt-common #224

Merged
merged 9 commits into from
May 6, 2024

Conversation

ganglyu
Copy link
Contributor

@ganglyu ganglyu commented Apr 30, 2024

Why I did it

Build pipeline is broken, and build error is introduced bye sonic-mgmt-common: sonic-net/sonic-mgmt-common#125

How I did it

Update go.mod and go.sum

How to verify it

Run azure pipeline to verify build

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

liuh-80
liuh-80 previously approved these changes Apr 30, 2024
@amrutasali
Copy link

amrutasali commented Apr 30, 2024

This change may not be needed once the sonic-mgmt-common submodule updates to https://github.com/sonic-net/sonic-buildimage/pull/18825/files that has the go.mod and go.sum changes.

Seems like the pipeline has not picked up the latest from sonic-mgmt-common and still points to old submodule and hence the pipeline failures for build step.

@ganglyu
Copy link
Contributor Author

ganglyu commented Apr 30, 2024

This change may not be needed once the sonic-mgmt-common submodule updates to https://github.com/sonic-net/sonic-buildimage/pull/18825/files that has the go.mod and go.sum changes.

Seems like the pipeline has not picked up the latest from sonic-mgmt-common and still points to old submodule and hence the pipeline failures for build step.

https://github.com/sonic-net/sonic-gnmi/blob/master/azure-pipelines.yml#L29-L33
Build pipeline is using sonic-mgmt-common master branch, I don't think it's related to submodule.

@amrutasali
Copy link

This change may not be needed once the sonic-mgmt-common submodule updates to https://github.com/sonic-net/sonic-buildimage/pull/18825/files that has the go.mod and go.sum changes.
Seems like the pipeline has not picked up the latest from sonic-mgmt-common and still points to old submodule and hence the pipeline failures for build step.

https://github.com/sonic-net/sonic-gnmi/blob/master/azure-pipelines.yml#L34-L38 Build pipeline is using sonic-swsscommon master branch, I don't think it's related to submodule.

ok got it

@ganglyu ganglyu requested a review from kwangsuk May 4, 2024 00:17
@liuh-80 liuh-80 mentioned this pull request May 6, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants