Add LDAP feature support #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidpil2002
force-pushed
the
dev-add-ldap-support
branch
from
a62b5a0
to
c897c79
Compare
|
/azpw run sonic-net.sonic-host-services |
|
/AzurePipelines run sonic-net.sonic-host-services |
|
Azure Pipelines successfully started running 1 pipeline(s). |
davidpil2002
force-pushed
the
dev-add-ldap-support
branch
from
7be802a
to
f1843e2
Compare
davidpil2002
force-pushed
the
dev-add-ldap-support
branch
4 times, most recently
from
360c770
to
44b07d1
Compare
|
@lguohan who should review and provide feedback? |
davidpil2002
force-pushed
the
dev-add-ldap-support
branch
from
44b07d1
to
a3f9072
Compare
davidpil2002
force-pushed
the
dev-add-ldap-support
branch
from
a3f9072
to
31b6555
Compare
davidpil2002
force-pushed
the
dev-add-ldap-support
branch
from
3fa0966
to
8105f4d
Compare
davidpil2002
force-pushed
the
dev-add-ldap-support
branch
from
9a95a54
to
ed10ab9
Compare
|
@lguohan / @qiluo-msft - are there any additional comments here? |
liat-grozovik
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added LDAP support to hostcfgd
LDAP HLD: sonic-net/SONiC#1487
This PR depends on the following PR: sonic-net/sonic-buildimage#16969
Details:
The fail (in the build check) reason is that this sonic-host-services LDAP unit tests have dependencies of the following PR: sonic-net/sonic-buildimage#16969
once the PR is merged, all the tests will pass