[cli-sessions] #99
Open
[cli-sessions] #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update hostcfgd: add serial-console and extend ssh-server modules, update existing tests, introduce serial-console test
|
Could you refine a meaningful PR title? |
liuh-80
reviewed
May 16, 2024
| self.render_conf_file() | ||
|
|
||
| # Read max_sessions config | ||
| def read_max_sessions_config(self, ssh_server_policies): | ||
| if ssh_server_policies is not None: |
There was a problem hiding this comment.
if not ssh_server_policies:
|
@i-davydenko please handle missing coverage |
…ntain max_sessions field.
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for cli-sessions feature
What I did:
Added handlers for new SSH_SERVER and SERIAL_CONSOLE attributes.
Why I did it:
Give ability to:
configure limit for active login sessions.
configure ssh-server / serial console autologout timeout
configure sysrq-capabilities (enable / disable)
How I did it
Add new service that responsible for serial configuration;
Update existing flows for extended ssh-server configurations in hostcfgd;
Add YANG model to support new configuration.
How I verified it:
Configure, reconfigure, and reset all new parameters, check if applicapple parameters was updated in the system.
Added unittests.
Signed-off-by: Ivan Davydenko ivanda@nvidia.com