Interface and Ethernet Counter support #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Satoru-Shinohara <satoru.shinohara@dell.com> Co-authored-by: Nikita Agarwal <nikita_agarwal1@dell.com>
Co-authored-by: Satoru-Shinohara <satoru.shinohara@dell.com> Co-authored-by: Nikita Agarwal <nikita_agarwal1@dell.com>
* add support for counters - top level and ethernet * Code Clean-up * Add subscription support for interface and ethernet counters * Update test-cases to support interface and ethernet state counters
* add support for counters - top level and ethernet * Code Clean-up * Add subscription support for interface and ethernet counters * Update test-cases to support interface and ethernet state counters * address azure-pipelines error
Satoru-Shinohara
force-pushed
the
ss-internal-review-may2
branch
from
0b5b2c4
to
fa5021c
Compare
Prasanth-KV
approved these changes
May 16, 2024
Prasanth-KV
approved these changes
May 16, 2024
Yes, clear counters will be supported in a later PR. Thank you for the review! |
kwangsuk
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for Interface and Ethernet counters.
This should address the pipeline test error that is caused by missing path.
Fail on UT-log are for tests that leave out ipv4-state as pipelines do not have APPL_DB while local switches do.
UT_run.log
translib_run.log
manual_GET_interface.log
manual_GET_interface_ethernet.log
Ethernet257 has a switch connected to it, and will have non-0 values.
Fail on on-change is because these attributes has on-change disabled in deviation.
on_change_subscription.log
target_defined_subscription.log
sample_subscription.log