Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pfc_gen_t2.py #11037

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update pfc_gen_t2.py #11037

wants to merge 1 commit into from

Conversation

harsgoll
Copy link
Contributor

While running PFCWD test cases, encountered concatenation issue on sonic fanout.

root@xx37-root-fanout:/tmp# sudo nice --20 python pfc_gen_t2.py -p 16 -t 65535 -s 8 -n 1000000 -i Ethernet152 -r 1.76.0.62 Traceback (most recent call last):
File "/tmp/pfc_gen_t2.py", line 340, in
main()
File "/tmp/pfc_gen_t2.py", line 264, in main
fo_logger.debug(fo_str + ' sendmmsg got errno ' + str(errno) + ' for socket ' + s.getsockname()) TypeError: can only concatenate str (not "tuple") to str

We converted s.getsockname() into str and able to proceed further.

Cc: sanjair-git, @rraghav-cisco

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

While running PFCWD test cases, encountered concatenation issue on sonic fanout.

root@xx37-root-fanout:/tmp# sudo nice --20 python pfc_gen_t2.py -p 16 -t 65535 -s 8 -n 1000000 -i Ethernet152 -r 1.76.0.62
Traceback (most recent call last):
File "/tmp/pfc_gen_t2.py", line 340, in
main()
File "/tmp/pfc_gen_t2.py", line 264, in main
fo_logger.debug(fo_str + ' sendmmsg got errno ' + str(errno) + ' for socket ' + s.getsockname())
TypeError: can only concatenate str (not "tuple") to str

We converted s.getsockname() into str and able to proceed further.

Cc: sanjair-git, @rraghav-cisco
@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/common/helpers/pfc_gen_t2.py:264:121: E501 line too long (121 > 120 characters)
tests/common/helpers/pfc_gen_t2.py:305:121: E501 line too long (121 > 120 characters)

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@rraghav-cisco
Copy link
Contributor

@sanjair-git : Pls review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants