Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some tests to verify Redis DB configuration #12877

Merged
merged 3 commits into from
May 30, 2024

Conversation

saiarcot895
Copy link
Contributor

@saiarcot895 saiarcot895 commented May 16, 2024

Description of PR

Add a test script to check that the redis config for the save setting, database count, and unix socket are correct. This can be extended to check for other config options.

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311

Approach

What is the motivation for this PR?

This is in response to sonic-net/sonic-buildimage#18979 and sonic-net/sonic-buildimage#18108, where with the database container upgrade to Bookworm, redis DB was configured to save to disk by default. This then caused issues in multi-ASIC setups.

How did you do it?

How did you verify/test it?

Tested on T0 KVM with sonic-net/sonic-buildimage#18979 applied.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Add a test script to check that the redis config for the save setting is
correct. This can be extended to check for other config options.

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...............................................................Passed
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/database/test_db_config.py:16:1: E302 expected 2 blank lines, found 1
tests/database/test_db_config.py:24:121: E501 line too long (142 > 120 characters)

flake8...............................................(no files to check)Skipped
check conditional mark sort..............................................Passed

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
@saiarcot895 saiarcot895 changed the title Add test to verify that the redis DB is not being saved to disk Add some tests to verify Redis DB configuration May 16, 2024
@saiarcot895
Copy link
Contributor Author

/azp run Azure.sonic-mgmt

Copy link

Commenter does not have sufficient privileges for PR 12877 in repo sonic-net/sonic-mgmt

@saiarcot895
Copy link
Contributor Author

/azpw run Azure.sonic-mgmt

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-mgmt

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yxieca yxieca merged commit 9684620 into sonic-net:master May 30, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants