Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip 'route/test_forced_mgmt_route.py' on 'Arista-7050CX3' platform #12896

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

anishb-arista
Copy link
Contributor

Description of PR

Summary:
Fixes #120

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311

Approach

What is the motivation for this PR?

The test route/test_forced_mgmt_route.py needs to be skipped on the platform Arista-7050 as the platform supports only one management interface

How did you do it?

Skipping the test on the platform Arista-7050 by updating the file tests/common/plugins/conditional_mark/tests_mark_conditions.yaml

How did you verify/test it?

Tested on Arista-7050 platform

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

…tform 'x86_64-arista_7050cx3_32s' because it supports only 1 management interface
@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...............................................................Passed
check for added large files..............................................Passed
check python ast.....................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
check conditional mark sort..............................................Failed
- hook id: check-conditional-mark-sort
- exit code: 1

The entries in tests/common/plugins/conditional_mark/tests_mark_conditions.yaml tests/common/plugins/conditional_mark/tests_mark_conditions_acl.yaml tests/common/plugins/conditional_mark/tests_mark_conditions_drop_packets.yaml tests/common/plugins/conditional_mark/tests_mark_conditions_platform_tests.yaml are not sorted in alphabetic order.

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

Copy link
Contributor

@Gfrom2016 Gfrom2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anishb-arista anishb-arista changed the title The test 'route/test_forced_mgmt_route.py' needs to be skipped on pla… Skip 'route/test_forced_mgmt_route.py' on 'Arista-7050CX3' platform May 24, 2024
@StormLiangMS StormLiangMS requested a review from liuh-80 May 30, 2024 08:58
@StormLiangMS
Copy link
Collaborator

Hi @liuh-80 could you help to review?

@wsycqyz
Copy link
Contributor

wsycqyz commented Jun 3, 2024

@anishb-arista Can you give more detail at which step in the testcase will add secondary mgmt interface?

@anishb-arista
Copy link
Contributor Author

@anishb-arista Can you give more detail at which step in the testcase will add secondary mgmt interface?

A second management interface is being added in this snippet -> https://github.com/sonic-net/sonic-mgmt/blob/master/tests/route/test_forced_mgmt_route.py#L133-L161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants