Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout in test_forced_mgmt_route to avoid flakiness and debug info in wait_until utility #13000

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AnantKishorSharma
Copy link
Contributor

Description of PR

  1. increased the timeout for /etc/network/interfaces file update
  2. changed the debug log in wait_until to print the actual time elapsed instead of timeout passed

Summary:
Increase the timeout in Fix route/test_forced_mgmt_route.py::test_update_forced_mgmt for /etc/network/interfaces file to get updated.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311

Approach

What is the motivation for this PR?

route/test_forced_mgmt_route.py::test_update_forced_mgmt failure on dualtor topo.

How did you do it?

increased the timeout

How did you verify/test it?

Verified that the tests are passing on dualtor-aa

NOK log excerpts:

15/05/2024 08:47:53 utilities.wait_until                     L0118 DEBUG  | Wait until hash_and_timestamp_changed is True, timeout is 10 seconds, checking interval is 1, delay is 0 seconds
…
15/05/2024 08:48:28 utilities.wait_until                     L0151 DEBUG  | hash_and_timestamp_changed is still False after 34 seconds, exit with False
15/05/2024 08:48:28 utilities.wait_until                     L0151 DEBUG  | hash_and_timestamp_changed is still False after 10 seconds, exit with False

UT:

-------------------------- generated xml file: /run_logs/ananshr/tr_2024-05-15-08-54-01.xml ---------------------------
----------------------------------------------- live log sessionfinish ------------------------------------------------
08:57:24 __init__.pytest_terminal_summary         L0064 INFO   | Can not get Allure report URL. Please check logs
====================================== 1 passed, 1 warning in 202.02s (0:03:22) =======================================

Any platform specific information?

NA

Supported testbed topology if it's a new test case?

NA

Documentation

NA

Copy link
Contributor

@wsycqyz wsycqyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AnantKishorSharma
Copy link
Contributor Author

AnantKishorSharma commented May 29, 2024

Same fix has been merged thru another PR 15 hours ago #12914

If we want we can merge the second part of changes in wait_until thru this PR to increase debuggability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants