Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[arp] Allow use of discontiguous ports with ARP tests. #3776

Merged
merged 2 commits into from
Apr 26, 2022
Merged

[arp] Allow use of discontiguous ports with ARP tests. #3776

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7d9a4d
[arp] Allow use of discontiguous ports with ARP tests.
Jul 12, 2021
b11d1ea
Addressing review comments
Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions tests/arp/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,23 @@ def intfs_for_test(duthosts, enum_rand_one_per_hwsku_frontend_hostname, enum_fro
intf1 = ports_for_test[0]
intf2 = ports_for_test[1]
else:
# Select port index 0 & 1 two interfaces for testing
intf1 = ports[0]
intf2 = ports[1]

# Select first 2 ports that are admin 'up'
intf_status = asic.show_interface(command='status')['ansible_facts']['int_status']

intf1 = None
intf2 = None
for a_port in ports:
if intf_status[a_port]['admin_state'] == 'up':
if intf1 is None:
intf1 = a_port
elif intf2 is None:
intf2 = a_port
else:
break

if intf1 is None or intf2 is None:
pytest.skip("Not enough interfaces on this host/asic (%s/%s) to support test." % (duthost.hostname,
asic.asic_index))
po1 = get_po(mg_facts, intf1)
po2 = get_po(mg_facts, intf2)

Expand Down