Instruction to set up virtual topology, test_bgp_scalability.py runs on vm and bug fixing #9214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* VM testbed set up documentation * bgp_test_gap_helper
yxieca
approved these changes
Aug 2, 2023
wangxin
approved these changes
Aug 3, 2023
Closed
6 tasks
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
What is the motivation for this PR? The primary motivation for these modifications was to set up a virtual machine (VM) topology and ensure that the 'test_bgp_scalability.py' runs smoothly on both VM and hardware setups. How did you do it? These improvements and fixes were achieved by adjusting the indexing in the 'bgp_test_gap_helper.py' file, adding logic to disable the 'EnableDataPlaneEventsRateMonitor' for VM setups, and fixing attribute errors. How did you verify/test it? The 'test_bgp_scalability.py' was run on both hardware and VM setups. Both setups passed the test as expected. Any platform specific information? IxNetwork Application Version: 9.30.2212.22 on a virtual machine, used for both VM and HW setups. IxChassis Application Version: 9.21 on a virtual machine and for the hardware setup. Application Version: 9.30 on two Load Module virtual machines attached to a virtual IxChassis. DUT SONiC-OS-202205.302215-e8e8c019c for VM setup. DUT SONiC-OS-202205.262571-f2a687b33 for the hardware setup. Documentation Instructions on setting up a VM topology for testing have been added. docs/testbed/README.testbed.Keysight.md docs/testbed/README.testbed.Setup.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
The 'conftest.py' file has been modified to include the Snappi OS.
Adjustments have been made in 'bgp_test_gap_helper.py' to make the indexing compatible with a chassis that has two ports.
The 'test_bgp_scalability.py' is now able to run on a VM by disabling the 'EnableDataPlaneEventsRateMonitor' if the setup is a VM type.
The line rate has been adjusted from 100 to 10, and from 50 to 5. This is due to the fact that the hardware setup results of the test do not depend on the line rate, but the VM does not support higher rates.
Traffic must now be stopped before obtaining the loss statistics.
Errors regarding the attributes 'lp1' and 'lp2' not having the 'protocol' attribute were fixed.
Documentation has been added on how to set up a VM topology.
Type of change
Back port request
Approach
What is the motivation for this PR?
The primary motivation for these modifications was to set up a virtual machine (VM) topology and ensure that the 'test_bgp_scalability.py' runs smoothly on both VM and hardware setups.
How did you do it?
These improvements and fixes were achieved by adjusting the indexing in the 'bgp_test_gap_helper.py' file, adding logic to disable the 'EnableDataPlaneEventsRateMonitor' for VM setups, and fixing attribute errors.
How did you verify/test it?
The 'test_bgp_scalability.py' was run on both hardware and VM setups. Both setups passed the test as expected.
Any platform specific information?
IxNetwork Application Version: 9.30.2212.22 on a virtual machine, used for both VM and HW setups.
IxChassis Application Version: 9.21 on a virtual machine and for the hardware setup.
Application Version: 9.30 on two Load Module virtual machines attached to a virtual IxChassis.
DUT SONiC-OS-202205.302215-e8e8c019c for VM setup.
DUT SONiC-OS-202205.262571-f2a687b33 for the hardware setup.
Documentation
Instructions on setting up a VM topology for testing have been added.
docs/testbed/README.testbed.Keysight.md
docs/testbed/README.testbed.Setup.md