Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RCA is When we are deleting the agent-id, hsflowd is referring to eth0 #9766

Merged
merged 1 commit into from
Sep 14, 2023
Merged

RCA is When we are deleting the agent-id, hsflowd is referring to eth0 #9766

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/sflow/test_sflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,7 @@ def testDelAgent(self, duthost, partial_ptf_runner):
# Verify whether the samples are received with previously configured agent ip
partial_ptf_runner(
polling_int=20,
agent_id=var['lo_ip'],
agent_id=var['mgmt_ip'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a change of behavior. Is this documented in the hsflowd release notes?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per this commit , When dynamic agent or agentIP override is removed, revert to automati… · sflow/host-sflow@7cb2b83 (github.com) and as per the discussion sflow/host-sflow#49 (comment) , whenever the agent-id is removed, agent IP address chosen should be unique persistent and reachable and it can reach to the collector IP. Currently when we are executing this script we got this below error,
image

After upgrading to 2.0.41, when the agent-id is deleted, it is expecting the management ip is the next preferred elected address to reach to the collector as per this script. So, we modified as per the behavior.
Attached the failed logs for more information.
test_sflow.log

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a hsflowd behavioral change. As long as it is documented, I am fine. @prsunny @padmanarayana FYI

active_collectors="['collector0','collector1']")

def testAddAgent(self, duthost, partial_ptf_runner):
Expand Down