[sonic_fw]: Add firmware management api base

[mudsut4ke]

Add base class for firmware management utillity (sonic-net/sonic-buildimage#2824)

Signed-off-by: Wirut Getbamrung wgetbumr@celestica.com

[lguohan]

in this case, i feel we should have CPLD1, CPLD2 as module name, each module will have only one version.

[mudsut4ke]

In that case,the list of supported module will be ["BIOS", "CPLD1", "CPLD2"] instead of ["BIOS", "CPLD"] and get_fw_version function should return only version string

Is that good?

[lguohan]

yes

[lguohan]

can you update the comments?

[jleveque]

@mudsut4ke: Is there any reason to keep this as a separate sonic_fw package, or would be better to add get_fw_version() and install_firmware() methods to the ChassisBase and ModuleBase classes sonic_platform_base?

[mudsut4ke]

@jleveque , Maybe a reason that firmware install tool is installed in sonic platform and cannot be used on pmon docker

[jleveque]

@mudsut4ke: Can you elaborate? We would like to consolidate all platform-specific abstraction into the new sonic_platform_base package.

If we were to install the sonic_platform_base package in both the pmon docker and also in the base image, would this suffice?

[mudsut4ke]

@jleveque , In my case the CPLD upgrade tool installed in base image (sonic-net/sonic-buildimage#2446)

if you install sonic_platform_base package in both the pmon docker and base image, that will cover my requirement

[mudsut4ke]

@jleveque , Any comment?

[jleveque]

I think it would be best to add this functionality to the ChassisBase and ModuleBase classes in the new platform API, and we can install the package in the base image as well as the pmon container.

[lguohan]

@mudsut4ke , any update on this?

[mudsut4ke]

@lguohan , I will move this tool to sonic_platform_base follow Joe suggesttion

@jleveque , In ChassisBase they Identified BIOS/FPGA/CPLD as component
Should I add new ComponentBase ? or Just add the firmware management to ModuleBase is enough ?

[jleveque]

@mudsut4ke: I think adding the firmware management functions to ChassisBase and ModuleBase is enough.

[mudsut4ke]

Move to #34