Added new APIs and enhanced the required APIs in "module_base.py and #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chassis_base.py" to support SmartSwitch
vvolam
reviewed
Jun 18, 2024
| """ | ||
| raise NotImplementedError | ||
|
|
||
| def get_state_info(self): |
There was a problem hiding this comment.
What is the difference between get_state_info and get_oper_status? Can you please add an example of the expected return value?
From the HLD, I understood that get_oper_status should return a simple online or offline state. And get_state_info should return the state progression. But from the description of the get_oper_status, it is different in this PR.
There was a problem hiding this comment.
Sure, will add an example of the return value.
| @@ -152,6 +170,11 @@ def get_oper_status(self): | |||
| A string, the operational status of the module from one of the | |||
| predefined status values: MODULE_STATUS_EMPTY, MODULE_STATUS_OFFLINE, | |||
| MODULE_STATUS_FAULT, MODULE_STATUS_PRESENT or MODULE_STATUS_ONLINE | |||
| The SmartSwitch platforms will have these additional status | |||
There was a problem hiding this comment.
This should remain the same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new APIs and enhanced the required APIs in "module_base.py and chassis_base.py" to support SmartSwitch
Description
The ChassisBase class and ModuleBase class need to support new SmartSwitch platforms.
Motivation and Context
Some new API and some API enhancements are required to support SmartSwitch. This has been captured in the PMON HLD document. These changes are implementation based on those requirements.
How Has This Been Tested?
The corresponding platform APIs were implemented. The new CLI changes and chassisd changes invoke these APIs. UT was performed and demo was done.
Additional Information (Optional)