Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tx_disable_channel with media_lanes_mask #353

Merged
merged 9 commits into from
May 12, 2023
Merged

Conversation

rajann
Copy link
Contributor

@rajann rajann commented May 3, 2023

Description

Invoke tx_disable_channel() api using the correct media_lanes_mask in case of subport shut/no shut operations

 (i.e) existing tx_disable_channel( ) api is being used with host_lanes_mask as of now.  
        This is not aligning with the subport concept where media_lane start wont match with host_lanes start.

As part of the fix, introduced an api to retrieve media_lanes_mask and use it as part of the tx_disable_channel() api

How Has This Been Tested?

Using 4x100G and 2x100G breakout modules

  • create 4 and 2 subports on 4x100G and 2x100G modules respectively.
  • Check whether all the subports are operationally up
  • Verify the upper page 10 for outputdisable values and page 11 for the data path state
  • Shut each subports one at a time and verify the operational status of every subports in this module
  • Unshut each subport one at a time and verify the operational status of every subports in this module
  • At each step verify the values in page10h and page 11h
  • Verified the subports with traffic

Invoke tx_disable_channel() api using the correct media_lanes_mask in case of subport shut/no shut operations
Copy link
Contributor

@mihirpat1 mihirpat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please help in resolving the test case failure seen with this changeset?

sonic-xcvrd/xcvrd/xcvrd.py Outdated Show resolved Hide resolved
sonic-xcvrd/xcvrd/xcvrd.py Outdated Show resolved Hide resolved
sonic-xcvrd/xcvrd/xcvrd.py Outdated Show resolved Hide resolved
@rajann
Copy link
Contributor Author

rajann commented May 5, 2023

Yes fixed the indentation issue and committed

sonic-xcvrd/xcvrd/xcvrd.py Show resolved Hide resolved
sonic-xcvrd/xcvrd/xcvrd.py Show resolved Hide resolved
sonic-xcvrd/xcvrd/xcvrd.py Show resolved Hide resolved
sonic-xcvrd/xcvrd/xcvrd.py Outdated Show resolved Hide resolved
@prgeor prgeor added the CMIS label May 12, 2023
@prgeor prgeor merged commit 1d79bb4 into sonic-net:master May 12, 2023
3 checks passed
yxieca pushed a commit that referenced this pull request May 24, 2023
* Use tx_disable_channel with media_lanes_mask

Invoke tx_disable_channel() api using the correct media_lanes_mask in case of subport shut/no shut operations
yxieca pushed a commit that referenced this pull request May 24, 2023
* Use tx_disable_channel with media_lanes_mask

Invoke tx_disable_channel() api using the correct media_lanes_mask in case of subport shut/no shut operations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants