Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dualtor] Fix command show mux status #371

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

lolyu
Copy link
Contributor

@lolyu lolyu commented Jun 5, 2023

Description

Fixes: #361
Fix the tardy command show mux status:

Jun  5 08:07:20.524687 lab-device-01 ERR pmon#CCmisApi: Exception occured at child thread YcableCliUpdateTask due to TypeError("handle_show_hwmode_state_cmd_arg_tbl_notification() missing 1 required positional argument: 'port'") Traceback (most recent call last):#012  File "/usr/local/lib/python3.9/dist-packages/ycable/ycable_utilities/y_cable_helper.py", line 4000, in run#012    self.task_cli_worker()#012  File "/usr/local/lib/python3.9/dist-packages/ycable/ycable_utilities/y_cable_helper.py", line 3864, in task_cli_worker#012    handle_show_hwmode_state_cmd_arg_tbl_notification(fvp, self.cli_table_helper.port_tbl, self.cli_table_helper.xcvrd_show_hwmode_dir_cmd_sts_tbl, self.cli_table_helper.xcvrd_show_hwmode_dir_rsp_tbl, self.cli_table_helper.xcvrd_show_hwmode_dir_res_tbl, asic_index, port)#012TypeError: handle_show_hwmode_state_cmd_arg_tbl_notification() missing 1 required positional argument: 'port'

MSFT:ADO: 24178563

Motivation and Context

How Has This Been Tested?

Additional Information (Optional)

Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
@yxieca yxieca merged commit b9d52d2 into sonic-net:master Jun 5, 2023
3 of 4 checks passed
yxieca pushed a commit that referenced this pull request Jun 5, 2023
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
yxieca added a commit that referenced this pull request Jun 6, 2023
yxieca added a commit that referenced this pull request Jul 7, 2023
yxieca pushed a commit that referenced this pull request Aug 29, 2023
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ycabled][dualtor][active-active] show mux status is slow and always return inconsistent HWSTATUS
2 participants