[System ready] Report ready status to Sysmonitor daemon

[fastiuk]

depends-on: sonic-net/sonic-buildimage#18817

Description

This change implements pmon's ability to report it's readines to sysmonitor

Motivation and Context

The motivation is to report the readiness of all SFPs to sysmonitor and not just the startup of pmon

How Has This Been Tested?

• Run NOS on the box
• Make sure pmon reports good readiness state and you can see it in sysmonitor

Additional Information (Optional)

[prgeor]

@fastiuk please update the details in the PR:-

Description
Motivation and Context
How Has This Been Tested?
Additional Information (Optional)`
``

[fastiuk]

Why do you correlate ready of syseeprom with pmon ready? There are many other initializations done in pmon like sfp, thermal etc. Shouldn't you set pmon status ready only after all these tasks are done?

@dgsudharsan I am not sure honestly. We had an internal requirement to declare ready status once all SFPs are accessible, so I did it exactly like that.

[dgsudharsan]

@keboliu @Junchao-Mellanox Can you please comment on this?

[Junchao-Mellanox]

i agree with @dgsudharsan , this is not the place to notify system ready. It is complicated to understand when SFP has been initialized. So I would prefer doing it simple.

My proposal:

1. set system not ready at line

   sonic-platform-daemons/sonic-xcvrd/xcvrd/xcvrd.py

   Line 2569 in 9ffce20

   self.log_error("Exiting main loop as child thread raised exception!")

   and line

   sonic-platform-daemons/sonic-xcvrd/xcvrd/xcvrd.py

   Line 2597 in 9ffce20

   sys.exit(SFP_SYSTEM_ERROR)

2. set system ready before line

   sonic-platform-daemons/sonic-xcvrd/xcvrd/xcvrd.py

   Line 2554 in 9ffce20

   self.stop_event.wait()