[xcvrd] Fix issue: logical_port_name is not defined #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keboliu
previously approved these changes
Apr 29, 2024
prgeor
previously approved these changes
Apr 29, 2024
|
@Junchao-Mellanox build is failing... |
mihirpat1
approved these changes
Apr 29, 2024
|
@Junchao-Mellanox Please help in fixing the code coverage check |
|
Hi @prgeor , UT added, could you please review? |
prgeor
approved these changes
Apr 30, 2024
|
@Junchao-Mellanox @prgeor I don't have enough information from PR comment to understand the change and issue it is addressing. Please update the PR comments with more information. @prgeor do you agree to backport this change? |
|
Hi @yxieca , I added some description. Please kindly review again. |
mssonicbld
pushed a commit
to mssonicbld/sonic-platform-daemons
that referenced
this pull request
May 16, 2024
* [xcvrd] Fix issue: logical_port_name is not defined * Add UT --------- Co-authored-by: Prince George <45705344+prgeor@users.noreply.github.com>
|
Cherry-pick PR to 202311: #488 |
mssonicbld
pushed a commit
that referenced
this pull request
May 16, 2024
* [xcvrd] Fix issue: logical_port_name is not defined * Add UT --------- Co-authored-by: Prince George <45705344+prgeor@users.noreply.github.com>
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The code uses a variable named "logical_port_name", but that variable is not defined in the code context. I believe the code was copied from some where without modifying the variable name. The PR is to fix it.
Motivation and Context
Fix issue: logical_port_name is not defined
How Has This Been Tested?
Manual test
Additional Information (Optional)