Don't process CMIS xcvrs on warm-reboot case #494
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking into unit test issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When warm-reboot happens xcvrd gets started it treats xcvrs as going through an insertion event. In the case of optics who on insertion event might need to be reprogrammed, it will force the TX off and disable them.
On warm-reboot, we don't want to do this - the xcvrs are already programmed correctly and it will impact dataplane traffic.
Motivation and Context
Interfaces with cmis optics in breakout configurations would stay down after warm-reboot cases in sonic-mgmt test runs.
How Has This Been Tested?
I tested this using a sonic-mgmt warm-reboot case where the optics would stay down and fail entire t0 runs. Those tests now pass and the interfaces stay up.
I also checked the flap counters on the peer for those interfaces - the link stayed up and did not flap - showing warm-reboot succeeded as expected.
Additional Information (Optional)