[xcvrd] Fix CMIS application selection to allow an app whose host lane count is less than the actual value #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wataru Ishida <wataru.ishid@gmail.com>
This commit fixes DPB support with CMIS transceivers. CmisManagerTask's `port_dict` must be updated according to the port add/remove events. This commit removes the `port_mapping` field from CmisManagerTask as `port_mapping` was mostly used just for storing `asic_id` information and that can be simply done by `port_dict` instead. Added a helper method `get_asic_id()` method to CmisManagerTask for getting `asic_id` from `logical_port`. fixes sonic-net/sonic-buildimage#18893 Signed-off-by: Wataru Ishida <wataru.ishid@gmail.com>
…he actual value Signed-off-by: Wataru Ishida <wataru.ishid@gmail.com>
prgeor
requested changes
Jul 5, 2024
There was a problem hiding this comment.
@ishidawataru I don't understand the constraint when you say Xcvrd is selecting the application based upon number of host lane count and speed. It should be like that. Why you think otherwise?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
get_cmis_application_desired()was choosing an app that matches both speed and host_lane_count of the port.This PR relaxes the constraint so that an app whose required host lane count is less than the actual value can be selected.
Motivation and Context
fixes sonic-net/sonic-buildimage#19336
How Has This Been Tested?
No E2E done yet. UT is added.
Additional Information (Optional)
#500 needs to be merged before this PR.