Add synchronization between SNMP MIBs and counters thread #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added check_ready() interface to suspend reinit_data/update_data untill a MIBUpdater child specific contition is met. Used this approach to suspend counters dependent MIBs untill counters polling thread is started. check_ready() might be usefull for transceiver or other MIBs as well but not scope of this change. Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to address sonic-net/sonic-buildimage#2750 by removing snmp.timer systemd unit and adding synchronization between counters and SNMP counter dependent MIBs
Added check_ready() interface to suspend reinit_data/update_data
untill a MIBUpdater child specific contition is met.
Used this approach to suspend counters dependent MIBs
untill counters polling thread is started.
check_ready() might be usefull for transceiver or other MIBs as well
but not scope of this change.
Signed-off-by: Stepan Blyschak stepanb@mellanox.com
- What I did
Add synchronization mechanism to MIBUpdater
Wait for counters to be ready before start polling from COUNTERS DB
- How I did it
Added check_ready() interface
- How to verify it
- Description for the changelog
Add synchronization mechanism to MIBUpdater
Wait for counters to be ready before start polling from COUNTERS DB