Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VoQ Recirc interface (i.e., Ethernet-Rec) to interface maps for S… #244

Merged
merged 9 commits into from
May 4, 2022

Conversation

ysmanman
Copy link
Contributor

@ysmanman ysmanman commented Mar 1, 2022

…yncD-connected MIB(s)

- What I did

VoQ inband port support was added in #228. This PR is to add support for VoQ recirc port.

This PR depends sonic-net/sonic-py-swsssdk#118, which defines index for VoQ recirc port.

- How I did it

- How to verify it

- Description for the changelog

@arlakshm
Copy link

arlakshm commented Mar 7, 2022

/Azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SuvarnaMeenakshi
Copy link
Contributor

Can you raise PR to update sub-module to include : sonic-net/sonic-py-swsssdk#118 so that snmpagent build succeeds.

@ysmanman
Copy link
Contributor Author

Can you raise PR to update sub-module to include : Azure/sonic-py-swsssdk#118 so that snmpagent build succeeds.

@SuvarnaMeenakshi Thanks for the reminder. Created PR sonic-net/sonic-buildimage#10220

@SuvarnaMeenakshi
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@arlakshm
Copy link

/Azp run Azure.sonic-snmpagent

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@arlakshm
Copy link

@ysmanman The test test_init_sync_d_interface_tables_for_recirc_ports is failing. Please take a look

@ysmanman
Copy link
Contributor Author

ysmanman commented May 3, 2022

@ysmanman The test test_init_sync_d_interface_tables_for_recirc_ports is failing. Please take a look

@arlakshm I fixed the test and it passed now.

Copy link
Contributor

@SuvarnaMeenakshi SuvarnaMeenakshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SuvarnaMeenakshi SuvarnaMeenakshi merged commit 5c08435 into sonic-net:master May 4, 2022
judyjoseph pushed a commit that referenced this pull request May 8, 2022
#244)

- What I did

VoQ inband port support was added in #228. This PR is to add support for VoQ recirc port.

This PR depends sonic-net/sonic-py-swsssdk#118, which defines index for VoQ recirc port.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants