-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support interface speed for PortChannels #262
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasstockner
force-pushed
the
port-channel-speed
branch
from
June 17, 2022 21:12
4a676e5
to
efb2ccc
Compare
Iteration over member interfaces is based on _get_counter. Signed-off-by: Lukas Stockner <lstockner@genesiscloud.com>
lukasstockner
force-pushed
the
port-channel-speed
branch
from
November 10, 2022 14:51
7a9e007
to
2faf305
Compare
qiluo-msft
pushed a commit
that referenced
this pull request
Sep 16, 2023
**- What I did** This change makes SNMP report the correct interface speed for PortChannels instead of defaulting to 40G. **- How I did it** Similar to `intfutil`, the code simply sums up the interface speeds of all member ports. The logic for iterating over members is based on `_get_counter`. **- How to verify it** - Check `snmpwalk -v 2c -c public <IP> ifHighSpeed`, note that PortChannels are reported as 40G - Apply the change - Check again, note that the same speed as in `show interface status` is reported now. **- Description for the changelog** Support reporting interface speeds for PortChannels through SNMP
what is the portchannel has no member ports? |
Tested on DUT, and it is working with PortChannel with no emmber ports.
|
yxieca
pushed a commit
that referenced
this pull request
Oct 13, 2023
**- What I did** This change makes SNMP report the correct interface speed for PortChannels instead of defaulting to 40G. **- How I did it** Similar to `intfutil`, the code simply sums up the interface speeds of all member ports. The logic for iterating over members is based on `_get_counter`. **- How to verify it** - Check `snmpwalk -v 2c -c public <IP> ifHighSpeed`, note that PortChannels are reported as 40G - Apply the change - Check again, note that the same speed as in `show interface status` is reported now. **- Description for the changelog** Support reporting interface speeds for PortChannels through SNMP
StormLiangMS
pushed a commit
that referenced
this pull request
Oct 17, 2023
**- What I did** This change makes SNMP report the correct interface speed for PortChannels instead of defaulting to 40G. **- How I did it** Similar to `intfutil`, the code simply sums up the interface speeds of all member ports. The logic for iterating over members is based on `_get_counter`. **- How to verify it** - Check `snmpwalk -v 2c -c public <IP> ifHighSpeed`, note that PortChannels are reported as 40G - Apply the change - Check again, note that the same speed as in `show interface status` is reported now. **- Description for the changelog** Support reporting interface speeds for PortChannels through SNMP
qiluo-msft
pushed a commit
that referenced
this pull request
Oct 20, 2023
**- What I did** This change makes SNMP report the correct interface speed for PortChannels instead of defaulting to 40G. **- How I did it** Similar to `intfutil`, the code simply sums up the interface speeds of all member ports. The logic for iterating over members is based on `_get_counter`. **- How to verify it** - Check `snmpwalk -v 2c -c public <IP> ifHighSpeed`, note that PortChannels are reported as 40G - Apply the change - Check again, note that the same speed as in `show interface status` is reported now. **- Description for the changelog** Support reporting interface speeds for PortChannels through SNMP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADO: 25085425
- What I did
This change makes SNMP report the correct interface speed for PortChannels instead of defaulting to 40G.
- How I did it
Similar to
intfutil
, the code simply sums up the interface speeds of all member ports. The logic for iterating over members is based on_get_counter
.- How to verify it
snmpwalk -v 2c -c public <IP> ifHighSpeed
, note that PortChannels are reported as 40Gshow interface status
is reported now.- Description for the changelog
Support reporting interface speeds for PortChannels through SNMP