Implement RFC4363 dot1qTpFdbTable Q-BRIDGE-MIB #3

qiluo-msft · 2017-01-23T21:48:10Z

No description provided.

tombo315

Looks good! Summarizing my comments:

double check that older UTs are passing
simplify the CME class by making a new type of MIBEntry subclass
general cleanup

tombo315 · 2017-01-24T02:02:42Z

src/ax_interface/mib.py

@@ -127,10 +135,16 @@ def __init__(self, subtree, sub_ids, value_type, callable_, *args, updater=None)

    def __iter__(self):
        for sub_id in self.sub_ids:
-            yield self.sub_id + (sub_id,)
+            if isinstance(sub_id, tuple):


Consider removing these if/else statements and moving the respective calls into their own class (avoiding any changes to CME)

class MIBSubtreeEntry(MIBEntry): def __init__(...): # impl def __iter__(self): # impl def __call__(self, sub_id_group) # impl

and remember to replace the type inspection for ContextualMIBEntry in the metaclass __new__ with MIBSubtreeEntry

#Resolved

Created a new MIBEntry subclass. Considering the dynamic OID feature, do some minor changes on existing CME class to facility the upper level implementation.

In reply to: 97460638 [](ancestors = 97460638)

tombo315 · 2017-01-24T02:04:00Z

src/sonic_ax_impl/mibs/ietf/__init__.py

@@ -0,0 +1,7 @@
+def mac_decimals(mac):


consider moving this into ax_interface/util.py #Resolved

tombo315 · 2017-01-24T02:08:52Z

src/sonic_ax_impl/mibs/ietf/rfc4363.py

+
+
+    def fdb_ifindex(self, sub_id):
+        assert sub_id is not None


consider using mibs.logger instead of assert.
consider throwing a ValueError instead #WontFix

It is an 'assert' in concept. So no need to fix.

In reply to: 97461221 [](ancestors = 97461221)

tombo315 · 2017-01-24T02:09:51Z

tests/test_fdb.py

+from ax_interface.constants import PduTypes
+from sonic_ax_impl.mibs import ieee802_1ab
+from sonic_ax_impl.mibs.ietf import rfc4363
+from sonic_ax_impl.main import SonicMIB


cleanup these imports #Resolved

tombo315 · 2017-01-24T02:11:22Z

src/sonic_ax_impl/mibs/ietf/rfc4363.py

+from enum import unique, Enum
+
+from sonic_ax_impl import mibs
+from sonic_ax_impl.mibs.ietf import *


I don't recommend import * in any production code. For the mac_decimals function (see my other comment) and:

from ax_interface import ..., util ``` #Resolved

tombo315 · 2017-01-24T02:15:44Z

tests/test_fdb.py

+class TestFdbMIB(TestCase):
+    @classmethod
+    def setUpClass(cls):
+        class FdbMIB(rfc4363.FdbMIB):


I don't see the intent of this declaration. #Resolved

tombo315 · 2017-01-24T07:26:36Z

src/sonic_ax_impl/mibs/ietf/rfc4363.py

+        assert sub_id is not None
+        return self.vlanmac_ifindex_map[sub_id]
+
+class FdbMIB(metaclass=MIBMeta, prefix='.1.3.6.1.2.1.17.7.1.2.2.1'):


update the readme with the RFC link

'Forwarding Database' https://tools.ietf.org/html/rfc4363 #Resolved

tombo315 · 2017-01-24T07:32:38Z

tests/test_fdb.py

+        #mib_entry = self.lut[(1, 3, 6, 1, 2, 1, 17, 7, 1, 2, 2, 1, 2, 1000, 124, 254, 144, 128, 159, 92)]
+
+    def test_getpdu(self):
+        get_pdu = GetPDU(


Changes were made to getnext.
Verify that other getnext/get UTs weren't affected.

Then, add an equivalent test for getnext from

(1, 3, 6, 1, 2, 1, 17, 7, 1, 2, 2, 1, 2) -- should find the first full vlan & mac

(1, 3, 6, 1, 2, 1, 17, 7, 1, 2, 2, 1, 3) -- should report no such object

#Resolved

qiluo-msft · 2017-02-01T23:16:11Z

@tombo315 This PR is still open to any comments.

Squashed commit of the following: commit 6c580806f962d508056e687108e04dc2a9df9276 Author: Qi Luo <qiluo-msft@users.noreply.github.com> Date: Fri Jan 26 15:08:53 2018 -0800 Fix queue counter value type, and wrap queue index (sonic-net#4) * Fix queue counter value type * Wrap queue index commit 66d738c297f852a5d504de1405ae55ff7d45dd0f Author: Qi Luo <qiluo-msft@users.noreply.github.com> Date: Fri Jan 26 02:44:32 2018 +0000 Added ciscoPfcExtMIB, ciscoSwitchQosMIB MIBs Squashed commit of the following: commit 0b68d9ed01ffe6a4b06345494e7bf7d3728c2371 Author: Qi Luo <qiluo-msft@users.noreply.github.com> Date: Thu Jan 25 18:27:53 2018 -0800 Fix PFC queue index base and value type (sonic-net#3) * Fix PFC queue index base * Fix pfc counter64 commit e84d1d89b8925cb547dfd435a5c1e8b58c74dedc Author: Qi Luo <qiluo-msft@users.noreply.github.com> Date: Tue Jan 23 23:59:51 2018 +0000 Added ciscoPfcExtMIB, ciscoSwitchQosMIB MIBs Squashed commit of the following: commit f0cbfff09066e372c1fe99983692a1dd719e5e80 Author: Qi Luo <qiluo-msft@users.noreply.github.com> Date: Tue Jan 23 23:20:02 2018 +0000 Fix Pfc/Qos counter integer range commit c954e4e44d1e44fc5b4b2269a5bbcee63aeb07c7 Author: AndriiS <andriis@mellanox.com> Date: Thu Jan 11 21:51:35 2018 +0200 Added ciscoPfcExtMIB, ciscoSwitchQosMIB MIBs (#1) Remove lag from csqIfQosGroupStatsTable (sonic-net#5)

Squashed commit of the following: commit 6c580806f962d508056e687108e04dc2a9df9276 Author: Qi Luo <qiluo-msft@users.noreply.github.com> Date: Fri Jan 26 15:08:53 2018 -0800 Fix queue counter value type, and wrap queue index (#4) * Fix queue counter value type * Wrap queue index commit 66d738c297f852a5d504de1405ae55ff7d45dd0f Author: Qi Luo <qiluo-msft@users.noreply.github.com> Date: Fri Jan 26 02:44:32 2018 +0000 Added ciscoPfcExtMIB, ciscoSwitchQosMIB MIBs Squashed commit of the following: commit 0b68d9ed01ffe6a4b06345494e7bf7d3728c2371 Author: Qi Luo <qiluo-msft@users.noreply.github.com> Date: Thu Jan 25 18:27:53 2018 -0800 Fix PFC queue index base and value type (#3) * Fix PFC queue index base * Fix pfc counter64 commit e84d1d89b8925cb547dfd435a5c1e8b58c74dedc Author: Qi Luo <qiluo-msft@users.noreply.github.com> Date: Tue Jan 23 23:59:51 2018 +0000 Added ciscoPfcExtMIB, ciscoSwitchQosMIB MIBs Squashed commit of the following: commit f0cbfff09066e372c1fe99983692a1dd719e5e80 Author: Qi Luo <qiluo-msft@users.noreply.github.com> Date: Tue Jan 23 23:20:02 2018 +0000 Fix Pfc/Qos counter integer range commit c954e4e44d1e44fc5b4b2269a5bbcee63aeb07c7 Author: AndriiS <andriis@mellanox.com> Date: Thu Jan 11 21:51:35 2018 +0200 Added ciscoPfcExtMIB, ciscoSwitchQosMIB MIBs (#1) Remove lag from csqIfQosGroupStatsTable (#5)

qiluo-msft added 8 commits January 23, 2017 21:40

(comment)

35350ff

Implement Dot1qTpFdbPort OIDs

a44152b

Unit test pass

9bbba32

Make doctest working

b3e067b

FDB entries are in ASIC_DB

b743ee9

Fix integration test

d34919d

Fix sub_id, add error handling

e37ce8f

Fix MIBEntry PREFIXLEN

123a775

tombo315 suggested changes Jan 24, 2017

View reviewed changes

tombo315 reviewed Jan 24, 2017

View reviewed changes

qiluo-msft added 8 commits January 25, 2017 21:51

Move common function

ae2d801

(update README)

ee71e02

Clean up import

982efb0

Fix: GetPDU contructs search range, add test case for GetNextPDU

4df9e0a

Refactor MIBSubtreeEntry

c66c09d

SubtreeMIBEntry supports dynamic OIDs

cf5353b

Simple refinement

0fbfba3

Clean code

e2942bf

pavel-shirshov approved these changes Feb 1, 2017

View reviewed changes

qiluo-msft merged commit fabc441 into sonic-net:master Feb 1, 2017

qiluo-msft deleted the qiluo/macvlan branch February 1, 2017 23:15

This was referenced Feb 2, 2017

Search Range "include" bit is ignored. #5

Open

"Dynamic Update" Implementation / Performance #7

Open

"sorted" usage should be eliminated during get-next calls #8

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement RFC4363 dot1qTpFdbTable Q-BRIDGE-MIB #3

Implement RFC4363 dot1qTpFdbTable Q-BRIDGE-MIB #3

qiluo-msft commented Jan 23, 2017

tombo315 left a comment

tombo315 Jan 24, 2017 •

edited by qiluo-msft

Loading

qiluo-msft Jan 31, 2017

tombo315 Jan 24, 2017 •

edited by qiluo-msft

Loading

tombo315 Jan 24, 2017 •

edited by qiluo-msft

Loading

qiluo-msft Jan 31, 2017

tombo315 Jan 24, 2017 •

edited by qiluo-msft

Loading

tombo315 Jan 24, 2017 •

edited by qiluo-msft

Loading

tombo315 Jan 24, 2017 •

edited by qiluo-msft

Loading

tombo315 Jan 24, 2017 •

edited by qiluo-msft

Loading

tombo315 Jan 24, 2017 •

edited by qiluo-msft

Loading

qiluo-msft commented Feb 1, 2017

Implement RFC4363 dot1qTpFdbTable Q-BRIDGE-MIB #3

Implement RFC4363 dot1qTpFdbTable Q-BRIDGE-MIB #3

Conversation

qiluo-msft commented Jan 23, 2017

tombo315 left a comment

Choose a reason for hiding this comment

tombo315 Jan 24, 2017 • edited by qiluo-msft Loading

Choose a reason for hiding this comment

qiluo-msft Jan 31, 2017

Choose a reason for hiding this comment

tombo315 Jan 24, 2017 • edited by qiluo-msft Loading

Choose a reason for hiding this comment

tombo315 Jan 24, 2017 • edited by qiluo-msft Loading

Choose a reason for hiding this comment

qiluo-msft Jan 31, 2017

Choose a reason for hiding this comment

tombo315 Jan 24, 2017 • edited by qiluo-msft Loading

Choose a reason for hiding this comment

tombo315 Jan 24, 2017 • edited by qiluo-msft Loading

Choose a reason for hiding this comment

tombo315 Jan 24, 2017 • edited by qiluo-msft Loading

Choose a reason for hiding this comment

tombo315 Jan 24, 2017 • edited by qiluo-msft Loading

Choose a reason for hiding this comment

tombo315 Jan 24, 2017 • edited by qiluo-msft Loading

Choose a reason for hiding this comment

qiluo-msft commented Feb 1, 2017

tombo315 Jan 24, 2017 •

edited by qiluo-msft

Loading

tombo315 Jan 24, 2017 •

edited by qiluo-msft

Loading

tombo315 Jan 24, 2017 •

edited by qiluo-msft

Loading

tombo315 Jan 24, 2017 •

edited by qiluo-msft

Loading

tombo315 Jan 24, 2017 •

edited by qiluo-msft

Loading

tombo315 Jan 24, 2017 •

edited by qiluo-msft

Loading

tombo315 Jan 24, 2017 •

edited by qiluo-msft

Loading

tombo315 Jan 24, 2017 •

edited by qiluo-msft

Loading