Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: add removeSelectable function in Select class #5

Merged
merged 1 commit into from
Apr 18, 2016

Conversation

stcheng
Copy link
Contributor

@stcheng stcheng commented Apr 12, 2016

Used by teamsyncd.

@@ -13,6 +13,18 @@ void Select::addSelectable(Selectable *c)
m_objects.push_back(c);
}

void Select::removeSelectable(Selectable *c)
{
for (auto i = m_objects.begin(); i != m_objects.end(); i++)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use find() on m_objects ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. i'll modify this.

@kcudnik
Copy link
Contributor

kcudnik commented Apr 18, 2016

Ack

@stcheng stcheng merged commit 0a19c2d into sonic-net:master Apr 18, 2016
@stcheng stcheng deleted the select branch April 18, 2016 21:43
zbud-msft pushed a commit to zbud-msft/sonic-swss-common that referenced this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants