Event and alarm management: Add tables for event and alarms. #852
Conversation
|
@bhaveshdell |
The PRs are listed in sonic-net/SONiC#1409 |
OK, so in all these two PRs to be reviewed? any more upcoming PR? |
@shyam77git Only these 2 PRs. Repo owner can add reviewer. |
|
/azpw run Azure.sonic-swss-common |
|
/AzurePipelines run Azure.sonic-swss-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
@prgeor / @zhangyanzhao - please add reviewers to this HLD. |
|
/azpw run Azure.sonic-swss-common |
|
/AzurePipelines run Azure.sonic-swss-common |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bhaveshdell
force-pushed
the
eventd-comm
branch
from
0423020
to
66724db
Compare
bhaveshdell
changed the title
|
@qiluo-msft @liuh-80 @shyam77git Please assign reviewers. Also, the build checks seem to be failing for reasons not related to the changes in this PR. Can you please check? |
bhaveshdell
force-pushed
the
eventd-comm
branch
from
66724db
to
3de7796
Compare
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@qiluo-msft @zbud-msft - Can we please get approval/merge on this PR? |
| @@ -23,6 +23,7 @@ namespace swss { | |||
| #define CHASSIS_APP_DB 12 | |||
| #define CHASSIS_STATE_DB 13 | |||
| #define APPL_STATE_DB 14 | |||
| #define EVENT_DB 19 | |||
There was a problem hiding this comment.
There is some redis configuration
# Set the number of databases. The default database is DB 0, you can select
# a different one on a per-connection basis using SELECT <dbid> where
# dbid is a number between 0 and 'databases'-1
databases 16
If the max number is less than 19, will your feature work? Could you break the build prcoess if it happen? #Closed
There was a problem hiding this comment.
The current max number is set to 100 as part of this change
https://github.com/sonic-net/sonic-buildimage/pull/17161/files#diff-88ce9c28933f9dd9c3009adba8ae67827831c0d7b7ad20c72556ae18b3764931
This feature creates an instance of DB, and the above change to 100 suffices this features requirement.
There was a problem hiding this comment.
@qiluo-msft Please approve/merge this PR if no further comments.
Why I did it
This PR contains code changes for providing extension to the Event Framework as specified in the sonic-net/SONiC#1409
How I did it
Followed design specified in sonic-net/SONiC#1409.
Add new tables for events and alarms.