[build]: Fix compiling warnings using ARM 32 bit compiler

[antony-rheneus]

What I did

Why I did it

How I verified it

Details if related

[antony-rheneus]

I couldn't understand the failure results, would you please provide suggestions to resolve it.

[qiluo-msft]

    ProducerStateTable *psTable, const uint32_t defaultWarmStartTimerValue = 0);

We also need change implementation to use mktime explicitly convert from uint32_t (or any other int type) to time_t #Closed

---

Refers to: warmrestart/warmRestartAssist.h:58 in 00c8c93. [](commit_id = 00c8c93, deletion_comment = False)

[qiluo-msft]

as comments

[stcheng]

please check

[antony-rheneus]

    ProducerStateTable *psTable, const uint32_t defaultWarmStartTimerValue = 0);

We also need change implementation to use mktime explicitly convert from uint32_t (or any other int type) to time_t

Refers to: warmrestart/warmRestartAssist.h:58 in 00c8c93. [](commit_id = 00c8c93, deletion_comment = False)

@qiluo-msft , I addressed as per your comments, changing from typecast to mktime()
however, typecast assigns the same value, whereas mktime() converts the time to different value. This would break the functionality.
#Closed

[antony-rheneus]

    ProducerStateTable *psTable, const uint32_t defaultWarmStartTimerValue = 0);

We also need change implementation to use mktime explicitly convert from uint32_t (or any other int type) to time_t
Refers to: warmrestart/warmRestartAssist.h:58 in 00c8c93. [](commit_id = 00c8c93, deletion_comment = False)

@qiluo-msft , I addressed as per your comments, changing from typecast to mktime()
however, typecast assigns the same value, whereas mktime() converts the time to different value. This would break the functionality.

@qiluo-msft , I suggest to revert the mktime() changes and go with typecasting approach

[qiluo-msft]

I could not understand

typecast assigns the same value, whereas mktime() converts the time to different value. This would break the functionality.

Could you clarify?

---

In reply to: 518963372 [](ancestors = 518963372)

[antony-rheneus]

I could not understand

typecast assigns the same value, whereas mktime() converts the time to different value. This would break the functionality.

Could you clarify?

In reply to: 518963372 [](ancestors = 518963372)

Original code:-
auto interv = timespec { .tv_sec = m_pollingInterval.count(), .tv_nsec = 0 };

Modified Code:-
tmInterval.tm_sec = m_pollingInterval.count();
auto interv = timespec { .tv_sec = mktime(&tmInterval), .tv_nsec = 0 };

In the above 2 cases, timespec.tv_sec values are NOT same. as mktime() returns a timestamp which is between given time since Unix Epoch.

[qiluo-msft]

Minor issues, otherwise looks good to me

Minor issues, otherwise looks good to me

[lguohan]

@qiluo-msft , can you approve?