[ci]: archive swss pytests #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guohan Lu <lguohan@gmail.com>
|
@lguohan I think you need to create the change for 202012 branch directly. This change cannot be cherry-picked cleanly. |
|
@lguohan , can we simple copy all the yaml files to the branch 202012? |
xumia
pushed a commit
to xumia/sonic-swss
that referenced
this pull request
Jun 2, 2021
in other pipelines, they will download swss and pytests. this is make sure the swss.deb and pytests are matched. Signed-off-by: Guohan Lu <lguohan@gmail.com>
xumia
added a commit
that referenced
this pull request
Jun 18, 2021
* [ci]: use build template (#1633) Signed-off-by: Guohan Lu <lguohan@gmail.com> * [ci]: run vstest Signed-off-by: Guohan Lu <lguohan@gmail.com> * [ci]: archive swss pytests (#1690) in other pipelines, they will download swss and pytests. this is make sure the swss.deb and pytests are matched. Signed-off-by: Guohan Lu <lguohan@gmail.com> * [ci]: Purge swss before install (#1654) Observe persistent failure of newly added vs test on testing code change in intfmgrd after migrating to azure pipeline. #1521 passed in legacy Jenkins pipeline. What we found is that the code change in the swss compiled with PR change is not properly installed in vs docker for a direct installation using dpkg -i. This is confirmed by verifying pipeline artifacts that md5sum value of /user/bin/intfmgrd changes if we install swss deb aritfact into the docker vs artifact, while that of /usr/bin/orchangent stays unchanged. md5sum before swss install in vs docker # md5sum /usr/bin/orchagent 28307a7805ea6f3bc5057c0257bf46e6 /usr/bin/orchagent # md5sum /usr/bin/intfmgrd fa2b06e20be683286adb47c55635a86d /usr/bin/intfmgrd md5sum after swss install # dpkg -i swss_1.0.0_amd64.deb (Reading database ... 19180 files and directories currently installed.) Preparing to unpack swss_1.0.0_amd64.deb ... Unpacking swss (1.0.0) over (1.0.0) ... Setting up swss (1.0.0) ... # md5sum /usr/bin/orchagent 28307a7805ea6f3bc5057c0257bf46e6 /usr/bin/orchagent # md5sum /usr/bin/intfmgrd e959340709e7aedd7489e69dfd19768f /usr/bin/intfmgrd Signed-off-by: Wenda Ni <wonda.ni@gmail.com> * Fix branch reference error * Fix branch reference error Co-authored-by: lguohan <lguohan@gmail.com> Co-authored-by: Wenda Ni <wonda.ni@gmail.com>
xumia
pushed a commit
to xumia/sonic-swss
that referenced
this pull request
Jun 25, 2021
in other pipelines, they will download swss and pytests. this is make sure the swss.deb and pytests are matched. Signed-off-by: Guohan Lu <lguohan@gmail.com>
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
in other pipelines, they will download swss and pytests. this is make sure the swss.deb and pytests are matched. Signed-off-by: Guohan Lu <lguohan@gmail.com>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
Signed-off-by: Neetha John <nejo@microsoft.com> Fixes sonic-net#1690 What I did Set the correct return code when pfcwd command is specified with invalid options How to verify it Modified the unit test to check for the correct return code and ran them and they passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guohan Lu lguohan@gmail.com
What I did
archive swss pytests to be used for other pipeline vstests
Why I did it
in other pipelines, they will download swss and pytests. this is make sure the swss.deb and pytests are matched.
How I verified it
Details if related