Add failure handling for SAI get operations #1768

shi-su · 2021-06-04T21:30:51Z

What I did
Add failure handling for SAI get operations. The function allows handling failures in SAI get operations according to the orch type, SAI type, SAI status.

Why I did it
Enable custom failure handling for SAI get operations.

How I verified it

Details if related

shi-su · 2021-06-14T19:14:16Z

/Azp run

azure-pipelines · 2021-06-14T19:14:45Z

Azure Pipelines successfully started running 1 pipeline(s).

shi-su · 2021-06-22T23:25:18Z

/Azp run

azure-pipelines · 2021-06-22T23:25:34Z

Azure Pipelines successfully started running 1 pipeline(s).

shi-su · 2021-06-24T16:42:10Z

/Azp run

azure-pipelines · 2021-06-24T16:42:28Z

Azure Pipelines successfully started running 1 pipeline(s).

orchagent/aclorch.cpp

orchagent/fdborch.cpp

orchagent/fgnhgorch.cpp

orchagent/orch.cpp

orchagent/portsorch.cpp

qiluo-msft

As comments

qiluo-msft · 2021-07-02T14:45:16Z

orchagent/natorch.cpp

@@ -115,6 +115,7 @@ NatOrch::NatOrch(DBConnector *appDb, DBConnector *stateDb, vector<table_name_wit
    if (status != SAI_STATUS_SUCCESS)
    {
        SWSS_LOG_NOTICE("Failed to get the SNAT available entry count, rv:%d", status);
+        handleSaiGetStatus(SAI_API_SWITCH, status);


handleSaiGetStatus

If this get api is not implemented, original code will log and continue, but new code will throw. Is it intended? #Closed

I thought the change is mainly intended to give enough warning when the SAI API is not implemented. Yet I do agree that this is not necessary for the scenarios where it could proceed without successful execution of the get operations. Removed the handling here and a few other similar scenarios.

qiluo-msft · 2021-07-04T09:14:55Z

Please fix the conflicts

shi-su · 2021-07-05T00:47:19Z

Please fix the conflicts

Done. Please help review again. Thanks.

What I did Add failure handling for SAI get operations. The function allows handling failures in SAI get operations according to the orch type, SAI type, SAI status. Why I did it Enable custom failure handling for SAI get operations.

What I did Backport SAI failure handling related commits into the 202012 branch. The following is a list of backported commits: 941875a Deactivate mirror session only when session status is true in updateLagMember (#1666) be12482 Ignore ALREADY_EXIST error in FDB creation (#1815) c9c1aa2 Add failure handling for SAI get operations (#1768) 47b4276 [BufferOrch] Don't call SAI API for BUFFER_POOL/PROFILE handling in case the op is DEL and the SAI OID is NULL (#1786) db9238f Add failure notification for orchagent (#1665) fc8e43f [synchronous mode] Add failure notification for SAI failures in synchronous mode (#1596) Why I did it 202012 image needs to include failure handling mechanism for enough notification in the presence of SAI failures.

What I did Add failure handling for SAI get operations. The function allows handling failures in SAI get operations according to the orch type, SAI type, SAI status. Why I did it Enable custom failure handling for SAI get operations.

…ers enablement after fast-reboot (sonic-net#1768) #### What I did Set flex counters delay indicator to prevent flex counters enablement after fast-reboot. #### How I did it Modify config DB json file with 'true' status for delay of flex counters indicator. #### How to verify it Run fast-reboot and observe counters are created only when enable_counters script is called, even if the tables are present in config DB.

shi-su force-pushed the handle_get branch from cfacdfc to 539b8fa Compare June 22, 2021 20:56

shi-su force-pushed the handle_get branch from 9c20c00 to fb88217 Compare June 23, 2021 16:14

shi-su force-pushed the handle_get branch from ac5d557 to 85e74c2 Compare June 28, 2021 17:47

shi-su marked this pull request as ready for review June 29, 2021 20:01

shi-su requested a review from prsunny as a code owner June 29, 2021 20:01

shi-su requested a review from qiluo-msft June 29, 2021 20:01