New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[orchagent] NVGRE Tunnel orchestration agent implementation #1953

Merged

liat-grozovik merged 35 commits into sonic-net:master from vadymhlushko-mlnx:nvgre_tunnel

Mar 15, 2022

Contributor

vadymhlushko-mlnx commented Oct 12, 2021 •

edited

DEPENDS ON:
sonic-swss-common/pull/549

What I did
Implemented the NVGRE Tunnel orchestration agent according to the - SONiC NVGRE Tunnel HLD

Why I did it

How I verified it
Implemented VS test.

Details if related

vadymhlushko-mlnx changed the title ~~Nvgre tunnel~~ NVGRE Tunnel orchestration agent implementation

vadymhlushko-mlnx mentioned this pull request

SONiC NVGRE Tunnel HLD sonic-net/SONiC#869

Merged

Contributor

caizhenghui-juniper commented Oct 12, 2021

Is there no dstIP? how do we setup encap of traffic through the tunnel?

Collaborator

liat-grozovik commented Oct 17, 2021

/azp run

azure-pipelines bot commented Oct 17, 2021

Azure Pipelines successfully started running 1 pipeline(s).

vadymhlushko-mlnx commented

View reviewed changes

tests/test_nvgre_tunnel.py Outdated Show resolved Hide resolved

vadymhlushko-mlnx commented

View reviewed changes

tests/test_nvgre_tunnel.py Outdated Show resolved Hide resolved

vadymhlushko-mlnx commented

View reviewed changes

tests/test_nvgre_tunnel.py Outdated Show resolved Hide resolved

vadymhlushko-mlnx commented

View reviewed changes

tests/test_nvgre_tunnel.py Outdated Show resolved Hide resolved

vadymhlushko-mlnx commented

View reviewed changes

tests/test_nvgre_tunnel.py Outdated Show resolved Hide resolved

vadymhlushko-mlnx commented

View reviewed changes

tests/test_nvgre_tunnel.py Outdated Show resolved Hide resolved

vadymhlushko-mlnx commented

View reviewed changes

tests/test_nvgre_tunnel.py Outdated Show resolved Hide resolved

vadymhlushko-mlnx commented

View reviewed changes

tests/test_nvgre_tunnel.py Outdated Show resolved Hide resolved

vadymhlushko-mlnx commented

View reviewed changes

tests/test_nvgre_tunnel.py Outdated Show resolved Hide resolved

vadymhlushko-mlnx commented

View reviewed changes

tests/test_nvgre_tunnel.py Outdated Show resolved Hide resolved

vadymhlushko-mlnx force-pushed the nvgre_tunnel branch from fb9b075 to 6b26af5 Compare

October 29, 2021 10:37

vadymhlushko-mlnx marked this pull request as ready for review

October 29, 2021 10:38

vadymhlushko-mlnx requested a review from prsunny as a code owner

October 29, 2021 10:38

vadymhlushko-mlnx changed the title ~~NVGRE Tunnel orchestration agent implementation~~ [orchagent] NVGRE Tunnel orchestration agent implementation

Contributor Author

vadymhlushko-mlnx commented Nov 1, 2021

/azpw run

Collaborator

mssonicbld commented Nov 1, 2021

/AzurePipelines run

azure-pipelines bot commented Nov 1, 2021

Azure Pipelines successfully started running 1 pipeline(s).

Collaborator

liat-grozovik commented Nov 15, 2021

@@kperumalbfn could you please help to review?
@vadymhlushko-mlnx please handle conflicts as soon as you can.

Contributor

kperumalbfn commented Nov 16, 2021

@liat-grozovik @mickeyspiegel is reviewing NVGRE tunnel PRs

vadymhlushko-mlnx force-pushed the nvgre_tunnel branch from 6b26af5 to b16ce16 Compare

November 16, 2021 09:46

Contributor Author

vadymhlushko-mlnx commented Nov 18, 2021

@mickeyspiegel, kind reminder, could you please help to review this PR

mickeyspiegel reviewed

View reviewed changes

orchagent/nvgreorch.cpp Show resolved Hide resolved

orchagent/nvgreorch.h Show resolved Hide resolved

orchagent/nvgreorch.cpp Show resolved Hide resolved

vadymhlushko-mlnx force-pushed the nvgre_tunnel branch from 83c9f1b to e991d29 Compare

December 6, 2021 11:51

vadymhlushko-mlnx added 2 commits

December 17, 2021 10:02


          Draft version of nvgre tunnel

6f4bfc0

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>


          Compiled

1db8139

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

vadymhlushko-mlnx added 4 commits

December 17, 2021 10:02


          Changed SAI attrs to NVGRE

a9b7ef2

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>


          Changed name of vlan -> vlan_id

a4d484a

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>


          Draft implementation of tunnel_termination

96c3441

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>


          Builded

9e58976

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

vadymhlushko-mlnx force-pushed the nvgre_tunnel branch from e991d29 to 3bfb894 Compare

December 21, 2021 14:39

Contributor Author

vadymhlushko-mlnx commented Dec 21, 2021

Is there no dstIP? how do we setup encap of traffic through the tunnel?

Currently, we add implementation only for the decap flow and it is L2 over L3 tunnel, so it should not be referenced by route objects. So at this point, you will be able to configure tunnel object and mapper entries for decap. This covers exactly the same use case as we have for L2 VXLAN, for example, please take a look at this test - test_vxlan_decap.py

Collaborator

liat-grozovik commented Jan 2, 2022

/azp run

azure-pipelines bot commented Jan 2, 2022

Azure Pipelines successfully started running 1 pipeline(s).

Collaborator

liat-grozovik commented Jan 26, 2022

/azp run

azure-pipelines bot commented Jan 26, 2022

Azure Pipelines successfully started running 1 pipeline(s).

Collaborator

liat-grozovik commented Jan 26, 2022

@mickeyspiegel could you please review recent changes following your feedback? if not more comments we will merge this PR

Contributor Author

vadymhlushko-mlnx commented Feb 21, 2022

/azpw run

Collaborator

mssonicbld commented Feb 21, 2022

/AzurePipelines run

azure-pipelines bot commented Feb 21, 2022

Azure Pipelines successfully started running 1 pipeline(s).

Collaborator

liat-grozovik commented Feb 24, 2022

/azp run Azure.sonic-swss

azure-pipelines bot commented Feb 24, 2022

Azure Pipelines successfully started running 1 pipeline(s).

Contributor Author

vadymhlushko-mlnx commented Feb 28, 2022

/azpw run

Collaborator

mssonicbld commented Feb 28, 2022

/AzurePipelines run

azure-pipelines bot commented Feb 28, 2022

Azure Pipelines successfully started running 1 pipeline(s).

Contributor Author

vadymhlushko-mlnx commented Mar 3, 2022

/azpw run

Collaborator

mssonicbld commented Mar 3, 2022

/AzurePipelines run

azure-pipelines bot commented Mar 3, 2022

Azure Pipelines successfully started running 1 pipeline(s).


          Fixed a delete flow of tunnel termination entry

6921aff

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

vadymhlushko-mlnx force-pushed the nvgre_tunnel branch from 3bfb894 to 6921aff Compare

March 3, 2022 14:19

Contributor Author

vadymhlushko-mlnx commented Mar 8, 2022 •

edited

@liat-grozovik
LGMT analysis failed not because of this PR.
LGTM analysis failed because it found minor (mostly code style) issues in already existing code in the sonic-swss submodule.

volodymyrsamotiy approved these changes

View reviewed changes

liat-grozovik approved these changes

View reviewed changes

liat-grozovik merged commit 0294376 into sonic-net:master

dprital pushed a commit to dprital/sonic-swss that referenced this pull request


          [orchagent] NVGRE Tunnel orchestration agent implementation (sonic-ne…

43a3424

…t#1953)

- What I did
Implemented the NVGRE Tunnel orchestration agent according to the - SONiC NVGRE Tunnel HLD

- Why I did it
Part of the NVGRE feature support.

- How I verified it
Implemented VS test.

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

preetham-singh pushed a commit to preetham-singh/sonic-swss that referenced this pull request


          [orchagent] NVGRE Tunnel orchestration agent implementation (sonic-ne…

4c2fef7

…t#1953)

- What I did
Implemented the NVGRE Tunnel orchestration agent according to the - SONiC NVGRE Tunnel HLD

- Why I did it
Part of the NVGRE feature support.

- How I verified it
Implemented VS test.

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mickeyspiegel mickeyspiegel left review comments

volodymyrsamotiy volodymyrsamotiy approved these changes

liat-grozovik liat-grozovik approved these changes

prsunny Awaiting requested review from prsunny prsunny is a code owner