[fdborch] Fix FDB flush issues #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandrx-kolomeiets
force-pushed
the
fix_fdb_flush
branch
3 times, most recently
from
0f8d83e
to
dda2284
Compare
oleksandrx-kolomeiets
force-pushed
the
fix_fdb_flush
branch
from
dda2284
to
50944f6
Compare
oleksandrx-kolomeiets
force-pushed
the
fix_fdb_flush
branch
from
50944f6
to
840a96a
Compare
|
can you please check the coverage - https://dev.azure.com/mssonic/build/_build/results?buildId=87118&view=codecoverage-tab You may want to add the VS test to cover the missing flows. |
oleksandrx-kolomeiets
force-pushed
the
fix_fdb_flush
branch
5 times, most recently
from
e2bf849
to
7a9625c
Compare
oleksandrx-kolomeiets
force-pushed
the
fix_fdb_flush
branch
3 times, most recently
from
0c404e2
to
1ab0895
Compare
Signed-off-by: Oleksandr Kolomeiets <oleksandrx.kolomeiets@intel.com>
oleksandrx-kolomeiets
force-pushed
the
fix_fdb_flush
branch
3 times, most recently
from
8eeb58b
to
e22d21c
Compare
|
@Praveen-Brcm, can you please help review this as well. |
msosyak
approved these changes
Jul 20, 2022
|
@gechiang, @Praveen-Brcm, please review the changes. Thanks! |
|
@oleksandrx-kolomeiets can you please take care of the EasyCLA check? There was an email sent to the community on how todo this one time registration which you need to do before the check can pass... @Praveen-Brcm Gentle reminder for you to review this PR. |
Praveen-Brcm
approved these changes
Aug 9, 2022
|
@gechiang : Changes looks good. |
|
@msosyak, @gechiang, @Praveen-Brcm, thank you for the review! |
lukasstockner
pushed a commit
to genesiscloud/sonic-swss
that referenced
this pull request
Nov 14, 2022
* [fdborch] Fix FDB flush issues Signed-off-by: Oleksandr Kolomeiets <oleksandrx.kolomeiets@intel.com> * Fix coverage * Fix test_FdbAddedAfterMemberCreated. * Fix flush_syncd_notif_ut.cpp.
lukasstockner
pushed a commit
to genesiscloud/sonic-swss
that referenced
this pull request
Mar 14, 2023
* [fdborch] Fix FDB flush issues Signed-off-by: Oleksandr Kolomeiets <oleksandrx.kolomeiets@intel.com> * Fix coverage * Fix test_FdbAddedAfterMemberCreated. * Fix flush_syncd_notif_ut.cpp.
lukasstockner
pushed a commit
to genesiscloud/sonic-swss
that referenced
this pull request
Apr 2, 2023
* [fdborch] Fix FDB flush issues Signed-off-by: Oleksandr Kolomeiets <oleksandrx.kolomeiets@intel.com> * Fix coverage * Fix test_FdbAddedAfterMemberCreated. * Fix flush_syncd_notif_ut.cpp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add a flag to FDB entry to ensure that only the requested FDB entries will be deleted on flush notification.
Why I did it
In the mclag scenario, restart one of a pair of leaf switches. After completing the information exchange between leaf switches, the leaf switch will flush the fdb and then add the fdb, and then if the downlink port down, the fdb will be redirected.
At this point, a bug may appear:
ERR swss#orchagent: :- meta_sai_validate_fdb_entry: object key SAI_OBJECT_TYPE_FDB_ENTRY:{"bvid":"oid:0x26000000000943","mac":"B4:56:B9:F0:00:3E","switch_id":"oid:0x21000000000000"} already exists
ERR swss#orchagent: :- addFdbEntry: Failed to create dynamic FDB b4:56:b9:f0:00:3e on Ethernet16, rv:-6
analysis：
flush fdb, there are three steps
If between step 1 and step 3, fdborch processes the event of adding fdb, it may cause the fdb cache in sairedis to be incorrect or the entries in ASIC_DB are incorrect.
In this way, subsequent additions and deletions will cause larger e exceptions.
How I verified it
flush fdb
add fdb to APPL_DB immediately
set this fdb again after
Details if related
Similar fix can be found in this PR #1470, but it has some flaws as mentioned in the comments.