Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aclorch] Fix and simplify DTel watchlist tables and entries #2155

Merged
merged 10 commits into from
Jun 17, 2022

Commits on Feb 22, 2022

  1. Fix DTel acl rule creation

    The significant rewrite of aclorch when adding ACL_TABLE_TYPE
    configuration caused a bug that prevents configuration of any
    DTel rules. This is due to use of an incorrect set of enum
    mappings while determining which type of AclRule to create.
    
    This commit changes that set of enum mappings.
    
    This also updates the list of actions in the DTel Flow and Drop
    watchlist tables so that they match the existing allowed actions
    in DTel acl rules.
    
    Signed-off-by: mickeyspiegel <mickey.spiegel@intel.com>
    mickeyspiegel committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    2402bad View commit details
    Browse the repository at this point in the history
  2. Remove DTel Drop Watchlist table and entry

    Since the 201911 release, the DTel drop actions have been supported in
    the DTel Flow Watchlist as well as the DTel Drop Watchlist. This allows
    for simplified operation where there is a single watchlist (DTel Flow
    Watchlist) that contains both flow and drop actions.
    
    The significant rewrite of aclorch when adding ACL_TABLE_TYPE
    configuration changed the way that the type of AclRule is determined.
    The current logic to distinguish between DTelFlow and DTelDrop AclRules
    is not correct. A fix to this logic would effectively remove the
    distinction between AclRules of type DTelFlow and DTelDrop, allowing
    for the larger set of actions supported by DTelFlow in either table.
    
    With this change in behavior, this seems like a good time to remove the
    DTel Drop Watchlist, leaving only the DTel Flow Watchlist that supports
    the superset of actions for both flow and drop.
    
    Signed-off-by: mickeyspiegel <mickey.spiegel@intel.com>
    mickeyspiegel committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    15f0b40 View commit details
    Browse the repository at this point in the history
  3. Terminology: DTelFlowWatchList to DTelWatchList

    Note: Leaving definition of TABLE_TYPE_DTEL_FLOW_WATCHLIST unchanged
          for backwards compatibility.
    
    Signed-off-by: mickeyspiegel <mickey.spiegel@intel.com>
    mickeyspiegel committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    59f5a25 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2022

  1. Configuration menu
    Copy the full SHA
    5478919 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2022

  1. Merge pull request #1 from KostiantynYarovyiBf/kyarovyi/acl-dtel-one-…

    …watchlist_tests
    
    [aclorch] Create sonic-swss tests for dtel acl
    mickeyspiegel committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    3fa44d8 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2022

  1. Add more fileds in DTEL ACL table

    Signed-off-by: Myron Sosyak <myronx.sosyak@intel.com>
    Myron Sosyak committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    b7bc595 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2 from msosyak/myron/extent_dtel_acl_table

    Extend DTEL ACL table
    mickeyspiegel committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    cbaf741 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2022

  1. Configuration menu
    Copy the full SHA
    394bc70 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2022

  1. Configuration menu
    Copy the full SHA
    3c1cd4a View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2022

  1. Configuration menu
    Copy the full SHA
    3af9488 View commit details
    Browse the repository at this point in the history