tlm_teamd: Filter portchannel subinterface events from STATE_DB LAG_TABLE #2408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid processing portchannel subinterfaces in teamd
|
@preetham-singh , can you please update the title correctly and also better description of the changes. Kindly follow the template and check-mark if the fix is required for any other branch. |
preetham-singh
changed the title
|
/easycla |
|
@judyjoseph pls help review and signoff |
judyjoseph
reviewed
Aug 18, 2022
judyjoseph
approved these changes
Aug 25, 2022
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Aug 29, 2022
Update sonic-swss submodule pointer to include the following: * Dynamic port configuration - add port buffer cfg to the port ref counter ([sonic-net#2194](sonic-net/sonic-swss#2194)) * tlm_teamd: Filter portchannel subinterface events from STATE_DB LAG_TABLE ([sonic-net#2408](sonic-net/sonic-swss#2408)) * [counters] Improve performance by polling only configured ports buffer queue/pg counters ([sonic-net#2360](sonic-net/sonic-swss#2360)) * added support for Xsight platform ([sonic-net#2426](sonic-net/sonic-swss#2426)) * [ci][asan] add DVS tests run with ASAN ([sonic-net#2363](sonic-net/sonic-swss#2363)) * Handle dual ToR neighbor miss scenario ([sonic-net#2151](sonic-net/sonic-swss#2151)) * Upstream new development on p4orch ([sonic-net#2237](sonic-net/sonic-swss#2237)) * [lgtm] Fix dependency ([sonic-net#2419](sonic-net/sonic-swss#2419)) * [muxorch] Returning true if nbr in skip_neighbor_ in isNeighborActive() ([sonic-net#2415](sonic-net/sonic-swss#2415)) * [macsec]: Set MTU for MACsec ([sonic-net#2398](sonic-net/sonic-swss#2398)) * Delete Invalid if condition in intfsorch.cpp ([sonic-net#2411](sonic-net/sonic-swss#2411)) Signed-off-by: dprital <drorp@nvidia.com>
7 tasks
yxieca
pushed a commit
that referenced
this pull request
Sep 1, 2022
…ABLE (#2408) * Fix for issue #11218 Avoid processing portchannel subinterfaces in teamd
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Sep 1, 2022
Update sonic-swss submodule pointer to include the following: * [BFD]Clean up state_db BFD entries on swss restart ([sonic-net#2434](sonic-net/sonic-swss#2434)) * Fix the Fec Mode Setting of gbsyncd ([sonic-net#2430](sonic-net/sonic-swss#2430)) * [neighsyncd] Enabling ipv4 link local entries for non-dualtor ([sonic-net#2427](sonic-net/sonic-swss#2427)) * tlm_teamd: Filter portchannel subinterface events from STATE_DB LAG_TABLE ([sonic-net#2408](sonic-net/sonic-swss#2408)) * PFCWD recovery changes using DLR_INIT ([sonic-net#2316](sonic-net/sonic-swss#2316)) * Dynamic port configuration - add port buffer cfg to the port ref counter ([sonic-net#2194](sonic-net/sonic-swss#2194)) Signed-off-by: dprital <drorp@nvidia.com>
7 tasks
dprital
added a commit
to dprital/sonic-swss
that referenced
this pull request
Sep 5, 2022
…DB LAG_TABLE (sonic-net#2408)" This reverts commit a2bac7c.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid processing portchannel subinterfaces in teamd
What I did
Fixes #11218 : sonic-net/sonic-buildimage#11218
As per Subinterface HLD, portchannel subinterfaces once provisioned by intfmgrd, will be updated to STATE_DB LAG_TABLE.
Teamd subscribes to STATE_DB LAG_TABLE hence it receives portchannel subinterface events though it is not interested in portchannel subinterface events.
Fix is to filter subinterface events prior to adding to teamd event queue.
Why I did it
Fix for issue #11218 where teamd syslog errors were observed when portchannel subinterfaces were configured on the system.
How I verified it
Ensured tlm does not add portchannel subinterface STATE_DB LAG_TABLE events to its event queue thus filtering portchannel subinterface events.
Details if related